-
Notifications
You must be signed in to change notification settings - Fork 110
Added Tooltips and label changes #10050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Tooltips and label changes #10050
Conversation
Summary of ChangesHello @bayakarisa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the user experience of the "QC Temperatures" feature under "Climatic > Check Data" by introducing informative tooltips for key controls and refining existing labels. These changes aim to make the interface more intuitive and user-friendly, particularly for understanding the various data quality check options. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
@rdstern are you happy with the new label names on this dialog? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Well done @bayakarisa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds tooltips and new labels to the QC Temperatures dialog. The changes are generally good and improve the user interface's clarity. I've identified a couple of areas for improvement:
- There's a naming inconsistency with one of the new UI controls in the designer file.
- The new tooltip texts are hardcoded, but the project has a translation mechanism that should be used for user-visible strings to support internationalization.
My detailed comments provide suggestions to address these points.
| Friend WithEvents lblRangeElement2From As Label | ||
| Friend WithEvents lblRangeElement1From As Label | ||
| Friend WithEvents ucrNudSameLabel As Label | ||
| Friend WithEvents UcrNudDifferenceLabel As Label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an inconsistent naming convention for this new control. Other controls in this file follow camelCase starting with a lowercase letter (e.g., ucrNudSameLabel). For consistency, please rename UcrNudDifferenceLabel to ucrNudDifferenceLabel throughout the file. This can be done by renaming the control in the Visual Studio designer.
Friend WithEvents ucrNudDifferenceLabel As Label
| ttOutliers.SetToolTip(ucrChkRangeElement1.chkCheck, "Flag values outside the acceptable range for Element 1") | ||
| ttOutliers.SetToolTip(ucrChkRangeElement2.chkCheck, "Flag values outside the acceptable range for Element 2") | ||
| ttOutliers.SetToolTip(ucrChkSame.chkCheck, "Flag values that occur for the specified number of consecutive days") | ||
| ttOutliers.SetToolTip(ucrChkJump.chkCheck, "Flag values where there are consecutive rows with a difference of a specified value") | ||
| ttOutliers.SetToolTip(ucrChkDifference.chkCheck, "Flag cases where Element 1 is less than or equal to Element 2") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tooltip strings are hardcoded. The project appears to have a translation mechanism (instat.Translations). To support internationalization, these user-visible strings should be wrapped with the translation function, likely Translations.GetTranslation().
ttOutliers.SetToolTip(ucrChkRangeElement1.chkCheck, Translations.GetTranslation("Flag values outside the acceptable range for Element 1"))
ttOutliers.SetToolTip(ucrChkRangeElement2.chkCheck, Translations.GetTranslation("Flag values outside the acceptable range for Element 2"))
ttOutliers.SetToolTip(ucrChkSame.chkCheck, Translations.GetTranslation("Flag values that occur for the specified number of consecutive days"))
ttOutliers.SetToolTip(ucrChkJump.chkCheck, Translations.GetTranslation("Flag values where there are consecutive rows with a difference of a specified value"))
ttOutliers.SetToolTip(ucrChkDifference.chkCheck, Translations.GetTranslation("Flag cases where Element 1 is less than or equal to Element 2"))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bayakarisa the tooltips look good
ba99e74
fixes #10037
Climatic > Check Data > QC Temperatures
Added Tooltips and label changes in QC Temperatures
@lilyclements @berylwaswa Kindly Check
