Skip to content

Conversation

@bayakarisa
Copy link
Collaborator

fixes #10037
Climatic > Check Data > QC Temperatures
Added Tooltips and label changes in QC Temperatures

@lilyclements @berylwaswa Kindly Check
image

@gemini-code-assist
Copy link

Summary of Changes

Hello @bayakarisa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the user experience of the "QC Temperatures" feature under "Climatic > Check Data" by introducing informative tooltips for key controls and refining existing labels. These changes aim to make the interface more intuitive and user-friendly, particularly for understanding the various data quality check options.

Highlights

  • Tooltips Added: Tooltips have been implemented for various checkboxes in the "QC Temperatures" dialog, providing clearer explanations for their functionality.
  • Label Enhancements: New labels, "Consecutive Days" and "greater than or equal to", have been introduced, and existing label positions adjusted for improved clarity in the "QC Temperatures" dialog.
  • UI Layout Adjustments: Minor layout changes, including control positioning and sizing, were made to accommodate the new labels and ensure a clean user interface.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@lilyclements
Copy link
Contributor

@rdstern are you happy with the new label names on this dialog?

lilyclements
lilyclements previously approved these changes Nov 1, 2025
Copy link
Contributor

@lilyclements lilyclements left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Well done @bayakarisa

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds tooltips and new labels to the QC Temperatures dialog. The changes are generally good and improve the user interface's clarity. I've identified a couple of areas for improvement:

  1. There's a naming inconsistency with one of the new UI controls in the designer file.
  2. The new tooltip texts are hardcoded, but the project has a translation mechanism that should be used for user-visible strings to support internationalization.

My detailed comments provide suggestions to address these points.

Friend WithEvents lblRangeElement2From As Label
Friend WithEvents lblRangeElement1From As Label
Friend WithEvents ucrNudSameLabel As Label
Friend WithEvents UcrNudDifferenceLabel As Label

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There's an inconsistent naming convention for this new control. Other controls in this file follow camelCase starting with a lowercase letter (e.g., ucrNudSameLabel). For consistency, please rename UcrNudDifferenceLabel to ucrNudDifferenceLabel throughout the file. This can be done by renaming the control in the Visual Studio designer.

    Friend WithEvents ucrNudDifferenceLabel As Label

Comment on lines +121 to +125
ttOutliers.SetToolTip(ucrChkRangeElement1.chkCheck, "Flag values outside the acceptable range for Element 1")
ttOutliers.SetToolTip(ucrChkRangeElement2.chkCheck, "Flag values outside the acceptable range for Element 2")
ttOutliers.SetToolTip(ucrChkSame.chkCheck, "Flag values that occur for the specified number of consecutive days")
ttOutliers.SetToolTip(ucrChkJump.chkCheck, "Flag values where there are consecutive rows with a difference of a specified value")
ttOutliers.SetToolTip(ucrChkDifference.chkCheck, "Flag cases where Element 1 is less than or equal to Element 2")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

These tooltip strings are hardcoded. The project appears to have a translation mechanism (instat.Translations). To support internationalization, these user-visible strings should be wrapped with the translation function, likely Translations.GetTranslation().

        ttOutliers.SetToolTip(ucrChkRangeElement1.chkCheck, Translations.GetTranslation("Flag values outside the acceptable range for Element 1"))
        ttOutliers.SetToolTip(ucrChkRangeElement2.chkCheck, Translations.GetTranslation("Flag values outside the acceptable range for Element 2"))
        ttOutliers.SetToolTip(ucrChkSame.chkCheck, Translations.GetTranslation("Flag values that occur for the specified number of consecutive days"))
        ttOutliers.SetToolTip(ucrChkJump.chkCheck, Translations.GetTranslation("Flag values where there are consecutive rows with a difference of a specified value"))
        ttOutliers.SetToolTip(ucrChkDifference.chkCheck, Translations.GetTranslation("Flag cases where Element 1 is less than or equal to Element 2"))

berylwaswa
berylwaswa previously approved these changes Nov 2, 2025
Copy link
Contributor

@berylwaswa berylwaswa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bayakarisa the tooltips look good

@bayakarisa bayakarisa dismissed stale reviews from berylwaswa and lilyclements via ba99e74 November 2, 2025 06:39
@lilyclements lilyclements merged commit e5d771f into IDEMSInternational:master Nov 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tooltips and label changes in QC Temperatures

3 participants