Skip to content

Conversation

@Ag-Derek
Copy link
Collaborator

@Ag-Derek Ag-Derek commented Nov 2, 2025

Fixes #10034
This adds the "To Script and OK" to the "To Script" Button
@lilyclements @berylwaswa this is ready for review

@gemini-code-assist
Copy link

Summary of Changes

Hello @Ag-Derek, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new 'To Script and OK' option to the existing 'To Script' dropdown menu, addressing issue #10034. This enhancement provides users with an additional workflow choice, allowing them to send content to the script window and simultaneously trigger an 'OK' action, thereby streamlining certain operations within the application.

Highlights

  • New Menu Item: A new menu item, 'To Script and OK', has been added to the dropdown list associated with the 'To Script' button.
  • Enhanced Functionality: This new option provides an additional workflow, allowing users to send content to the script window and then trigger an 'OK' action simultaneously.
  • UI Adjustments: The user interface layout, specifically the size of the context menu and the parent button control, has been updated to properly accommodate the newly added menu item.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new 'To Script and OK' option to the 'To Script' button's context menu. The changes correctly add the new UI element and its event handler. However, I've found a critical issue in the event handler logic where an action is performed twice due to a redundant method call. I've provided a suggestion to fix this. Additionally, there's a minor UI inconsistency in the text casing of the new menu item, for which I've also suggested a correction to maintain consistency across the UI.

Copy link
Contributor

@lilyclements lilyclements left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ag-Derek nice! Works well for me

@berylwaswa over to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "To Script and OK" button

2 participants