-
Notifications
You must be signed in to change notification settings - Fork 110
Added "To Script and Ok" as a 3rd item in the drop-down list with the "To script" button #10051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Added "To Script and Ok" as a 3rd item in the drop-down list with the "To script" button #10051
Conversation
…To script" button.
Summary of ChangesHello @Ag-Derek, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new 'To Script and OK' option to the existing 'To Script' dropdown menu, addressing issue #10034. This enhancement provides users with an additional workflow choice, allowing them to send content to the script window and simultaneously trigger an 'OK' action, thereby streamlining certain operations within the application. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new 'To Script and OK' option to the 'To Script' button's context menu. The changes correctly add the new UI element and its event handler. However, I've found a critical issue in the event handler logic where an action is performed twice due to a redundant method call. I've provided a suggestion to fix this. Additionally, there's a minor UI inconsistency in the text casing of the new menu item, for which I've also suggested a correction to maintain consistency across the UI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ag-Derek nice! Works well for me
@berylwaswa over to you
Fixes #10034
This adds the "To Script and OK" to the "To Script" Button
@lilyclements @berylwaswa this is ready for review