Skip to content

Commit 04963c2

Browse files
committed
Implicit concatenation: Ensure backward compatibility
1 parent fb0837f commit 04963c2

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

src/rpft/parsers/creation/contentindexparser.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -219,9 +219,11 @@ def _process_data_sheet(self, row):
219219
if len(sheet_names) > 1:
220220
LOGGER.warning(
221221
"Implicitly concatenating data sheets without concat operation "
222-
"is not supported anymore. Ignoring all but the first sheet."
222+
"is deprecated and may be removed in the future."
223223
)
224-
data_sheet = self._get_new_data_sheet(sheet_names[0], row.data_model)
224+
data_sheet = self._data_sheets_concat(sheet_names, row.data_model)
225+
else:
226+
data_sheet = self._get_new_data_sheet(sheet_names[0], row.data_model)
225227

226228
else:
227229
if not row.new_name:

tests/test_contentindexparser.py

+7
Original file line numberDiff line numberDiff line change
@@ -841,6 +841,13 @@ def test_two_fresh_sheets(self):
841841
)
842842
self.check_concat()
843843

844+
def test_two_fresh_sheets_implictly(self):
845+
self.ci_sheet = csv_join(
846+
"type,sheet_name,data_sheet,data_row_id,new_name,data_model,operation.type",
847+
"data_sheet,simpleA;simpleB,,,simpledata,SimpleRowModel,",
848+
)
849+
self.check_concat()
850+
844851
def test_fresh_and_existing_sheets(self):
845852
self.ci_sheet = csv_join(
846853
"type,sheet_name,data_sheet,data_row_id,new_name,data_model,operation.type",

0 commit comments

Comments
 (0)