Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Belgian German to dialect-map #97

Open
JorisLemay opened this issue Jan 4, 2025 · 4 comments
Open

Add Belgian German to dialect-map #97

JorisLemay opened this issue Jan 4, 2025 · 4 comments
Assignees
Labels
enhancement New feature or request fixed-in-dev

Comments

@JorisLemay
Copy link

Fix

Please add Belgian German in the language-refset-dialect-map.properties file. Vielen Dank für Ihre Aufmerksamkeit für unsere Dreisprachigkeit :) .

suggestion for fix in src/main/resources/language-refset-dialect-map.properties add:

# 120961000172108 | Belgian German language reference set (foundation metadata concept)|
# Combined as: de-be
120961000172108=be

Error/Warning

Command and warning.

$ java --add-opens java.base/java.lang=ALL-UNNAMED -Xms4g \
    -jar                   ./snomed-tools/snomed-to-owl-toolkit/snomed-owl-toolkit-5.3.0-executable.jar \
    -rf2-to-owl            ./snomed-tools/sct-releases/sct-int_and_be-ontology-2025-01-04_13-56-11.owl \
    -rf2-snapshot-archives ./snomed-tools/sct-releases/SnomedCT_InternationalRF2_PRODUCTION_20250101T120000Z.zip,\
./snomed-tools/sct-releases/SnomedCT_ManagedServiceBE_PRODUCTION_BE1000172_20241215T120000Z.zip
 
2025-01-04 12:59:05,518 [WARN  ] [main] org.snomed.otf.owltoolkit.ontology.OntologyService - Please add language reference set 120961000172108 to language-refset-dialect-map.properties and recompile. The dialect ISO code could not be appended to the annotations because it was not found.
@pgwilliams pgwilliams self-assigned this Jan 6, 2025
@pgwilliams pgwilliams added enhancement New feature or request fixed-in-dev labels Jan 6, 2025
@pgwilliams
Copy link
Member

😄 Your phrase was worth the effort of translating there; you're welcome. And thanks for providing the config required.

Committed to our develop branch bc22531

I'll have a chat with the team tomorrow about cutting release 5.5 as part of our current round of development work.

@pgwilliams
Copy link
Member

@JorisLemay were you able to get going with a locally modified properties file, or should we add capability / instructions on how to do that? It seems like a problem that any new edition is going to encounter.

@JorisLemay
Copy link
Author

JorisLemay commented Jan 6, 2025

@JorisLemay were you able to get going with a locally modified properties file, or should we add capability / instructions on how to do that? It seems like a problem that any new edition is going to encounter.

German SCT is not currently in the picture, but it would definitely be nice to include once it’s ready. The principal issue here is managing the requirements for new editions effectively. Here are my proposed options to address this:
1. Add a “Definition of Done” or “Feature Checklist”: Incorporate a check for supported languages (like German SCT) into the owl-toolkit release process. This ensures language compatibility is verified before finalizing a release.
2. Make Language Configurable: Extend the configuration options in a par file used with the release JAR. This could include feature flags for supported languages, OWL format options, or other related configurations to improve flexibility and adaptability.

@kaicode
Copy link
Member

kaicode commented Jan 6, 2025

I agree that it would be nice to be able to add language refsets without recompiling the jar file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed-in-dev
Projects
None yet
Development

No branches or pull requests

3 participants