cpp11 compatible int128

Author: inkrement

CMakeLists.txt

@@ -29,6 +29,7 @@ PROJECT (CLICKHOUSE-CLIENT)
     SUBDIRS (
         clickhouse
         contrib/cityhash
+        contrib/abseil-cpp
         contrib/lz4
     )
 

clickhouse/CMakeLists.txt

@@ -32,12 +32,16 @@ SET_TARGET_PROPERTIES(clickhouse-cpp-lib PROPERTIES LINKER_LANGUAGE CXX)
 TARGET_LINK_LIBRARIES (clickhouse-cpp-lib
     cityhash-lib
     lz4-lib
+    absl::numeric
+    absl::strings
 )
 
 ADD_LIBRARY (clickhouse-cpp-lib-static STATIC ${clickhouse-cpp-lib-src})
 TARGET_LINK_LIBRARIES (clickhouse-cpp-lib-static
     cityhash-lib
     lz4-lib
+    absl::numeric
+    absl::strings
 )
 
 IF (CMAKE_CXX_COMPILER_ID STREQUAL "Clang")

clickhouse/columns/decimal.cpp

@@ -1,5 +1,6 @@
 #include "decimal.h"
 
+#include <absl/strings/numbers.h>
 #include <iostream>
 
 namespace clickhouse {
@@ -61,10 +62,13 @@ void ColumnDecimal::Append(const std::string& value) {
 
             has_dot = true;
         } else if (*c >= '0' && *c <= '9') {
-            if (__builtin_mul_overflow(int_value, 10, &int_value) ||
-                __builtin_add_overflow(int_value, *c - '0', &int_value)) {
-                throw std::runtime_error("value is too big for 128-bit integer");
-            }
+            int_value *= 10;
+            int_value += *c - '0';
+            // TODO: check overflows
+            //if (__builtin_mul_overflow(int_value, 10, &int_value) ||
+            //    __builtin_add_overflow(int_value, *c - '0', &int_value)) {
+            //    throw std::runtime_error("value is too big for 128-bit integer");
+            //}
         } else {
             throw std::runtime_error(std::string("unexpected symbol '") + (*c) + "' in decimal value");
         }
@@ -76,9 +80,11 @@ void ColumnDecimal::Append(const std::string& value) {
     }
 
     while (zeros) {
-        if (__builtin_mul_overflow(int_value, 10, &int_value)) {
-            throw std::runtime_error("value is too big for 128-bit integer");
-        }
+        int_value *= 10;
+        // TODO: check overflows
+        //if (__builtin_mul_overflow(int_value, 10, &int_value)) {
+        //    throw std::runtime_error("value is too big for 128-bit integer");
+        //}
         --zeros;
     }
 

clickhouse/columns/numeric.h

@@ -1,5 +1,6 @@
 #pragma once
 
+#include <absl/numeric/int128.h>
 #include "column.h"
 
 namespace clickhouse {
@@ -48,7 +49,7 @@ class ColumnVector : public Column {
     std::vector<T> data_;
 };
 
-using Int128 = __int128;
+using Int128 = absl::int128;
 
 using ColumnUInt8   = ColumnVector<uint8_t>;
 using ColumnUInt16  = ColumnVector<uint16_t>;

clickhouse/types/types.h

@@ -1,12 +1,15 @@
 #pragma once
 
+#include <absl/numeric/int128.h>
+
 #include <map>
 #include <memory>
 #include <string>
 #include <vector>
 
 namespace clickhouse {
 
+using Int128 = absl::int128;
 using TypeRef = std::shared_ptr<class Type>;
 
 class Type {
@@ -200,7 +203,7 @@ inline TypeRef Type::CreateSimple<int64_t>() {
 }
 
 template <>
-inline TypeRef Type::CreateSimple<__int128>() {
+inline TypeRef Type::CreateSimple<Int128>() {
     return TypeRef(new Type(Int128));
 }