hadProtocol should target nsg:Protocol objects

[wizmer]

In

neuroshapes/modules/simulation/src/main/resources/schemas/neurosciencegraph/simulation/bluepyefefeatures/v0.1.3.json

Line 36 in c35a5de

"class": "nsg:Entity",

the hadProtocol property targets "nsg:Entity". Shouldn't it target "nsg:Protocol" ?

[MFSY]

Yes it should to be consistent.

[Ritikseptember2003]

@wizmer
You are correct that the nsg:hadProtocol property, based on its description - "Experimental protocols which produced traces having extracted features (protocols.json)" — should logically target "nsg:Protocol" rather than "nsg:Entity".

The reasons are:

• Semantic Precision
• Alignment with Description
• Consistency

Some fixes also we can do like:

Replace
{
"path": "nsg:hadProtocol",
"description": "Experimental protocols which produced traces having extracted features(protocols.json)",
"class": "nsg:Entity",
"minCount": 1,
"maxCount": 1
}
with
{
"path": "nsg:hadProtocol",
"description": "Experimental protocols which produced traces having extracted features(protocols.json)",
"class": "nsg:Protocol",
"minCount": 1,
"maxCount": 1
}