Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataverse External Author Vocabulary error when sending ORCID values to DataCite #11242

Open
Esteban-Mtz opened this issue Feb 11, 2025 · 2 comments · May be fixed by #11246
Open

Dataverse External Author Vocabulary error when sending ORCID values to DataCite #11242

Esteban-Mtz opened this issue Feb 11, 2025 · 2 comments · May be fixed by #11246
Labels
Type: Bug a defect

Comments

@Esteban-Mtz
Copy link
Contributor

What steps does it take to reproduce the issue?

  1. Activate CVocConf (https://github.com/gdcc/dataverse-external-vocab-support/blob/main/examples/authorIDandAffilationUsingORCIDandROR.md)
  2. Create Dataset
  3. Introduce any author using ORCID author functionality
  4. Publish Dataset

When does this issue occur?

  • While publishing Dataset.

Which page(s) does it occurs on?

  • You can see it on this page: $SERVER/api/datasets/export?exporter=Datacite&persistentId=doi:xxxx/xxxx, after Dataset publication.

What happens?

To whom does it occur (all users, curators, superusers)?

  • All users

What did you expect to happen?

  • Datacite recived ORCID fields and Datacite Metadata export was correct.

Which version of Dataverse are you using?

  • 6.4

Any related open or closed issues to this bug report?

  • No

Screenshots:

  • ORCID author functionality
    Image

  • Hidden Identifier Field
    Image

  • Database Registry
    Image

  • Datacite Metadata export
    Image

  • Datacite Test Registry
    Image

Are you thinking about creating a pull request for this issue?
Help is always welcome, is this bug something you or your organization plan to fix?

  • Correct Datacite Metadata export
    Image

  • Correct Datacite Test Registry
    Image

  • Code Change Possible Solution
    Image
@Esteban-Mtz Esteban-Mtz added the Type: Bug a defect label Feb 11, 2025
@qqmyers
Copy link
Member

qqmyers commented Feb 11, 2025

Thanks for the report! Looks like that didn't get caught in testing (QA or unit tests (because the ORCID value used is "AuthorIdentifier1").

At QDR, where the recent DataCite XML updates started, we have a similar fix to your in ExternalIdentifier (from 2021) that caused this bug to not be seen/ apply there. That fix is a change to the pattern: https://github.com/QualitativeDataRepository/dataverse/blob/e61419987387597ac8abc524a600b04833366782/src/main/java/edu/harvard/iq/dataverse/ExternalIdentifier.java#L7

and a change in the formatting: https://github.com/QualitativeDataRepository/dataverse/blob/e61419987387597ac8abc524a600b04833366782/src/main/java/edu/harvard/iq/dataverse/ExternalIdentifier.java#L59-L64

I also see that this change could have avoided creating two ROR checkers that was recently done:

dataverse/src/main/java/edu/harvard/iq/dataverse/ExternalIdentifier.java

Lines 17 to 19 in 106fb6f

ROR("ROR", "https://ror.org/%s", "^0[a-hj-km-np-tv-z|0-9]{6}[0-9]{2}$"),
// In some contexts, we check for the full ROR URL.
ROR_FULL_URL("ROR", "https://ror.org/%s", "^(https:\\/\\/ror.org\\/)0[a-hj-km-np-tv-z|0-9]{6}[0-9]{2}$");

Unless you'd like to submit a PR, I'd be happy to create a small one to get this fix into v6.6. Just let me know.

@Esteban-Mtz
Copy link
Contributor Author

Hi @qqmyers you can create small PR to fix it.

Best Regards.

@qqmyers qqmyers linked a pull request Feb 12, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug a defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

IQSS/11242 ExternalIdentifier fix QualitativeDataRepository/dataverse
2 participants
@qqmyers @Esteban-Mtz