fix test properly, don't just delete it

Author: DominicOram

block_utils.py

@@ -86,7 +86,7 @@ def format_block_value(val, precision):
     assert small_number_threshold < big_number_threshold
 
     # No precision specified = do not format.
-    if precision is None or precision < 0:
+    if precision is None or not isinstance(precision, int) or precision < 0:
         return u"{}".format(val)
     try:
         float_val = float(val)

tests/test_block_utils.py

@@ -516,12 +516,30 @@ def test_GIVEN_a_block_with_a_number_that_does_not_fit_in_a_float_WHEN_formatted
 
         self.assertEqual(format_block_value(value, 3), expected_formatted_value)
 
+    def test_GIVEN_arbitrary_object_as_precision_WHEN_formatting_THEN_original_value_returned_unchanged(self):
+        precision = object()
+        value = "12.345"
+
+        self.assertEqual(format_block_value(value, precision), value)
+
     def test_GIVEN_negative_precision_WHEN_formatting_THEN_original_value_returned_unchanged(self):
         precision = -57
         value = "12.345"
 
         self.assertEqual(format_block_value(value, precision), value)
 
+    def test_GIVEN_nonsense_precision_WHEN_formatting_THEN_original_value_returned_unchanged(self):
+        precision = "this is clearly not a valid precision"
+        value = "12.345"
+
+        self.assertEqual(format_block_value(value, precision), value)
+
+    def test_GIVEN_nonsense_precision_containing_unicode_WHEN_formatting_THEN_original_value_returned_unchanged(self):
+        precision = u"ƀ Ɓ Ƃ ƃ Ƅ ƅ Ɔ Ƈ ƈ Ɖ Ɗ Ƌ ƌ ƍ Ǝ Ə Ɛ Ƒ ƒ Ɠ Ɣ ƕ Ɩ Ɨ Ƙ ƙ ƚ ƛ Ɯ Ɲ ƞ Ɵ Ơ ơ Ƣ ƣ Ƥ ƥ Ʀ Ƨ ƨ Ʃ ƪ ƫ Ƭ ƭ Ʈ"
+        value = "12.345"
+
+        self.assertEqual(format_block_value(value, precision), value)
+
 
 if __name__ == '__main__':
     unittest.main()