Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bibliography: Need to Render Additional Metadata Fields #88

Open
mdalmau opened this issue Oct 13, 2020 · 4 comments
Open

Bibliography: Need to Render Additional Metadata Fields #88

mdalmau opened this issue Oct 13, 2020 · 4 comments
Labels
awaiting signoff Fix has been attempted and needs confirmation that it's done prod testing Issue reported during testing of the production web site

Comments

@mdalmau
Copy link
Collaborator

mdalmau commented Oct 13, 2020

Publishers are not listed in the full bibliography page. When there’s a printer, they does show up, but I that’s because printers are encoded differently from publishers. Other contributors are also not showing up (e.g. Elias Ashmole for #Ashmole1652). Reported by Alex Wingate.
@mdalmau mdalmau added the prod testing Issue reported during testing of the production web site label Oct 13, 2020
@mdalmau
Copy link
Collaborator Author

mdalmau commented Oct 13, 2020

Alex is reviewing this in the bibliography encoding, but it will also require an XSLT update: https://github.com/IUBLibTech/newton_chymistry/blob/master/xslt/bibliography-to-html.xsl

Conal-Tuohy added a commit that referenced this issue Oct 14, 2020
@Conal-Tuohy
render publisher and date in bibliography, to fix issue #88
79e1604
@Conal-Tuohy
Copy link
Collaborator

Publication Year was also missing. Now fixed on my dev VM and ready to be deployed at IU and signed off.

@mdalmau
Copy link
Collaborator Author

mdalmau commented Oct 14, 2020

@Conal-Tuohy, sounds like this will require a merge on Carbon, yes? Let me know when the pull request is up and I can follow-up with @randalldfloyd

@Conal-Tuohy
Copy link
Collaborator

@mdalmau again, I didn't make a pull request; I simply pushed the fix to this repository's master branch. See above

@mdalmau mdalmau added the awaiting signoff Fix has been attempted and needs confirmation that it's done label Dec 10, 2020
@tubesoft tubesoft mentioned this issue Dec 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
awaiting signoff Fix has been attempted and needs confirmation that it's done prod testing Issue reported during testing of the production web site
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdalmau @Conal-Tuohy