Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserEntity might be dangerous #7

Open
mateusz opened this issue Oct 5, 2018 · 1 comment
Open

UserEntity might be dangerous #7

mateusz opened this issue Oct 5, 2018 · 1 comment

Comments

@mateusz
Copy link
Collaborator

mateusz commented Oct 5, 2018

I think UserEntity should not be a proxy global state because it could be dangerous or lead to confusion. As an example of how the problem can manifest see the comment here 2be7b46 .

It looks like the interface is intended to represent an actual object, so it should be tied explicitly and permanently to one concrete Member.

This is a bit arbitrary though - so asking for your feedback - is my concern legitimate?

@IanSimpson
Copy link
Owner

Honestly, I have no idea. A long time since I was actively working on this code. My first instinct is that I know the library is absolutely incomplete, and lightly tested, so it's quite likely there are a lot of sub-ideal things in there...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants