Remove unnecessary type hints

Author: raviks789

application/controllers/EventRuleController.php

@@ -47,9 +47,7 @@ public function indexAction(): void
         $this->addTitleTab(t('Event Rule'));
         $this->controls->addAttributes(['class' => 'event-rule-detail']);
 
-        /** @var string $ruleId */
         $ruleId = $this->params->getRequired('id');
-        /** @var array<string, mixed>|null $configValues */
         $configValues = $this->sessionNamespace->get($ruleId);
         $this->controls->addAttributes(['class' => 'event-rule-detail']);
 
@@ -96,7 +94,6 @@ public function indexAction(): void
             })
             ->handleRequest($this->getServerRequest());
 
-        /** @var array<string, mixed> $cache */
         $cache = $this->sessionNamespace->get($ruleId);
         $discardChangesButton = null;
         if ($cache !== null) {
@@ -189,7 +186,6 @@ public function fromDb(int $ruleId): array
         foreach ($rule->rule_escalation as $re) {
             foreach ($re as $k => $v) {
                 if (in_array($k, ['id', 'condition'])) {
-                    /** @var int|string|null $v */
                     $config[$re->getTableName()][$re->position][$k] = (string) $v;
                 }
             }
@@ -244,7 +240,6 @@ public function searchEditorAction(): void
 
         $editor = new SearchEditor();
 
-        /** @var string $objectFilter */
         $objectFilter = $eventRule['object_filter'] ?? '';
         $editor->setQueryString($objectFilter)
             ->setAction(Url::fromRequest()->getAbsoluteUrl())
@@ -296,7 +291,6 @@ public function editAction(): void
     {
         /** @var string $ruleId */
         $ruleId = $this->params->getRequired('id');
-        /** @var array<string, mixed>|null $config */
         $config = $this->sessionNamespace->get($ruleId);
         if ($config === null) {
             if ($ruleId === '-1') {

application/controllers/EventRulesController.php

@@ -163,10 +163,7 @@ public function addAction(): void
 
     public function searchEditorAction(): void
     {
-        /** @var string $ruleId */
         $ruleId = $this->params->shiftRequired('id');
-
-        /** @var array<string, mixed>|null $eventRule */
         $eventRule = $this->sessionNamespace->get($ruleId);
 
         if ($eventRule === null) {
@@ -175,7 +172,6 @@ public function searchEditorAction(): void
 
         $editor = new SearchEditor();
 
-        /** @var string $objectFilter */
         $objectFilter = $eventRule['object_filter'] ?? '';
         $editor->setQueryString($objectFilter)
             ->setAction(Url::fromRequest()->getAbsoluteUrl())

application/forms/EventRuleConfigElements/EscalationCondition.php

@@ -41,7 +41,6 @@ protected function assemble(): void
         // Escalation Id to which the condition belongs
         $this->addElement('hidden', 'id');
 
-        /** @var SubmitButtonElement $addCondition */
         $addCondition = $this->createElement(
             'submitButton',
             'add-condition',

application/forms/EventRuleConfigElements/EscalationRecipient.php

@@ -29,7 +29,6 @@ protected function assemble(): void
     {
         $this->addElement('hidden', 'recipient-count', ['value' => '1']);
 
-        /** @var SubmitButtonElement $addRecipientButton */
         $addRecipientButton = $this->createElement(
             'submitButton',
             'add-recipient',
@@ -69,7 +68,6 @@ protected function assemble(): void
 
             $options = $defaultOption + Channel::fetchChannelNames(Database::get());
 
-            /** @var SelectElement $val */
             $val = $this->createElement(
                 'select',
                 'val_' . $i,
@@ -81,7 +79,6 @@ protected function assemble(): void
                 ]
             );
 
-            /** @var string $recipientVal */
             $recipientVal = $this->getValue('column_' . $i);
             if ($recipientVal !== null) {
                 $recipient = explode('_', $recipientVal);
@@ -200,7 +197,6 @@ public function getRecipients(): array
             $count += 1;
         }
 
-        /** @var array<int, array<string, mixed>> $values */
         $values = [];
         for ($i = 1; $i <= $count; $i++) {
             if ($i === (int) $removePosition) {

application/forms/EventRuleConfigForm.php

@@ -339,7 +339,6 @@ public function getValues(): array
     {
         $values = [];
         $escalations = [];
-        /** @var string $prefixesString */
         $prefixesString = $this->getValue('prefixes-map', '');
 
         /** @var string[] $prefixesMap */
@@ -442,7 +441,6 @@ public function addOrUpdateRule(int $id, array $config): int
         $escalationsFromDb = RuleEscalation::on($db)
             ->filter(Filter::equal('rule_id', $id));
 
-        /** @var array<int, array<string, mixed>> $escalationsInCache */
         $escalationsInCache = $config['rule_escalation'];
 
         $escalationsToUpdate = [];
@@ -504,7 +502,6 @@ private function insertOrUpdateEscalations(int $ruleId, array $escalations, bool
     {
         $db = Database::get();
         foreach ($escalations as $position => $escalationConfig) {
-            /** @var array<int, array<string, mixed>> $recipientsFromConfig */
             $recipientsFromConfig = $escalationConfig['recipients'] ?? [];
             if ($insert) {
                 $db->insert('rule_escalation', [
@@ -515,7 +512,6 @@ private function insertOrUpdateEscalations(int $ruleId, array $escalations, bool
                     'fallback_for' => $escalationConfig['fallback_for'] ?? null
                 ]);
 
-                /** @var string $escalationId */
                 $escalationId = $db->lastInsertId();
             } else {
                 /** @var string $escalationId */
@@ -555,7 +551,6 @@ function (array $element) use ($recipientId) {
                 }
             }
 
-            /** @var array<string, mixed> $recipientConfig */
             foreach ($recipientsFromConfig as $recipientConfig) {
                 $data = [
                     'rule_escalation_id' => $escalationId,