ui: Change visualization of redundancy group states

They can now be unreachable, thus get the same icon as others.
The state then isn't about reachability anymore, so it's just
critical or ok.

Author: nilmerg

library/Icingadb/Model/RedundancyGroupState.php

@@ -5,13 +5,15 @@
 namespace Icinga\Module\Icingadb\Model;
 
 use DateTime;
+use Icinga\Module\Icingadb\Common\Icons;
 use ipl\Orm\Behavior\Binary;
 use ipl\Orm\Behavior\BoolCast;
 use ipl\Orm\Behavior\MillisecondTimestamp;
 use ipl\Orm\Behaviors;
 use ipl\Orm\Model;
 use ipl\Orm\Query;
 use ipl\Orm\Relations;
+use ipl\Web\Widget\Icon;
 
 /**
  * Redundancy group state model.
@@ -66,9 +68,27 @@ public function createRelations(Relations $relations): void
         $relations->belongsTo('redundancy_group', RedundancyGroup::class);
     }
 
+    /**
+     * Get the state text for the redundancy group state
+     *
+     * Do not use this method to label the state of a redundancy group.
+     *
+     * @return string
+     */
     public function getStateText(): string
     {
-        // The method should only be called to fake state balls and not to show the group's state
-        return $this->failed ? 'unreachable' : 'reachable';
+        return $this->failed ? 'critical' : 'ok';
+    }
+
+    /**
+     * Get the state icon
+     *
+     * @return ?Icon
+     */
+    public function getIcon(): ?Icon
+    {
+        if (! $this->is_reachable) {
+            return new Icon(Icons::UNREACHABLE);
+        }
     }
 }

library/Icingadb/Widget/Detail/RedundancyGroupHeader.php

@@ -29,7 +29,10 @@ public function __construct(RedundancyGroup $object, RedundancyGroupSummary $sum
 
     protected function assembleVisual(BaseHtmlElement $visual): void
     {
-        $visual->addHtml(new StateBall($this->object->state->getStateText(), $this->getStateBallSize()));
+        $stateBall = new StateBall($this->object->state->getStateText(), $this->getStateBallSize());
+        $stateBall->add($this->object->state->getIcon());
+
+        $visual->addHtml($stateBall);
     }
 
     protected function assembleTitle(BaseHtmlElement $title): void

library/Icingadb/Widget/ItemList/RedundancyGroupListItem.php

@@ -62,7 +62,10 @@ protected function createSubject(): Link
 
     protected function assembleVisual(BaseHtmlElement $visual): void
     {
-        $visual->addHtml(new StateBall($this->state->getStateText(), $this->getStateBallSize()));
+        $stateBall = new StateBall($this->state->getStateText(), $this->getStateBallSize());
+        $stateBall->add($this->state->getIcon());
+
+        $visual->addHtml($stateBall);
     }
 
     protected function assembleCaption(BaseHtmlElement $caption): void

public/css/common.less

@@ -412,13 +412,3 @@ form[name="form_confirm_removal"] {
   padding: 0 0.25em;
   .rounded-corners();
 }
-
-.state-ball {
-  &.state-unreachable {
-    background-color: @color-critical;
-  }
-
-  &.state-reachable {
-    background-color: @color-ok;
-  }
-}