Skip to content

DeprecationWarnings with current release 1.9.0 #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sallner opened this issue Apr 22, 2024 · 4 comments · Fixed by #158
Closed

DeprecationWarnings with current release 1.9.0 #157

sallner opened this issue Apr 22, 2024 · 4 comments · Fixed by #158
Assignees
Labels

Comments

@sallner
Copy link

sallner commented Apr 22, 2024

I use cryptojwt = 1.8.3 and cryptography = 42.0.5 and I get the following DeprecationWarning:

def new_ec_key(crv, kid="", **kwargs):
  _key = ec.generate_private_key(curve=NIST2SEC[crv], backend=default_backend())

E cryptography.utils.CryptographyDeprecationWarning: Curve argument must be an instance of an EllipticCurve class. Did you pass a class by mistake? This will be an exception in a future version of cryptography.

As I try to get rid of DeprecationWarnings preemptively, I asked myself if there is the intention to change the behaviour in cryptojwt soon and how I could help with that. I already upgraded to the newest release cryptojwt = 1.9.0, but the warning is still there.

@jschlyter jschlyter self-assigned this Apr 22, 2024
@jschlyter jschlyter added the bug label Apr 22, 2024
@jschlyter
Copy link
Collaborator

Yes, it seems like a bug. I'll look into it!

@jschlyter
Copy link
Collaborator

@sallner please try fix in #158

@jschlyter
Copy link
Collaborator

ping @sallner

@jschlyter
Copy link
Collaborator

1.9.1 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants