Skip to content

Add option ignore_invalid_keys to KeyBundle #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2020
Merged

Add option ignore_invalid_keys to KeyBundle #69

merged 2 commits into from
Oct 7, 2020

Conversation

jschlyter
Copy link
Collaborator

  • If set to True (default), silently ignore invalid keys.
  • If set to False, raise exception when processing keys.

closes #63

@jschlyter
Add option accept_invalid_keys to KeyBundle
53a3565 
- If set to True (default), silently ignore invalid keys.
- If set to False, raise exception when processing keys.
@jschlyter jschlyter requested review from rohe and angelakis September 23, 2020 06:59
@jschlyter
Copy link
Collaborator Author

ping @rohe @angelakis

rohe
rohe approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@rohe rohe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really happy with the name but not going to fight getting it changed.

@jschlyter
Copy link
Collaborator Author

Not really happy with the name but not going to fight getting it changed.

If @angelakis has better naming proposal, I'm all for it.

@jschlyter
Copy link
Collaborator Author

ping @angelakis

@jschlyter
Copy link
Collaborator Author

Timeout from @angelakis, will ask @janste63 review before merging.

@jschlyter jschlyter removed the request for review from angelakis October 7, 2020 12:43
@jschlyter jschlyter changed the title Add option accept_invalid_keys to KeyBundle Add option ignore_invalid_keys to KeyBundle Oct 7, 2020
@jschlyter jschlyter merged commit 88bfcec into IdentityPython:develop Oct 7, 2020
@jschlyter jschlyter deleted the accept_invalid_keys branch October 7, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohe rohe rohe approved these changes

@janste63 janste63 janste63 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KeyBundle's do_keys ignores invalid keys
3 participants
@jschlyter @rohe @janste63