Skip to content

Remove RSA1_5 from Documentation example #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
peppelinux opened this issue May 21, 2021 · 4 comments · Fixed by #89
Closed

Remove RSA1_5 from Documentation example #88

peppelinux opened this issue May 21, 2021 · 4 comments · Fixed by #89

Comments

@peppelinux
Copy link
Member

As RSA 1.5 has been deprecated here:
#86

we should update the examples in the Documentation with another algorithm, eg: "RSA-OAEP" or any other.

@rohe
Copy link
Contributor

rohe commented May 21, 2021

Agree, we should replace RSA1_5 with RSA-OAEP where appropriate.

@rohe
Copy link
Contributor

rohe commented May 21, 2021

A quick search also reveals RSA1_5 in a couple of tests and in src/cryptojwt/jwt.py and src/cryptojwt/jwk/wrap.py .
We can replace i tests but changing jwt.py and wrap.py is trickier. That could easily be a breaking change.

@peppelinux
Copy link
Member Author

peppelinux commented May 21, 2021

A quick search also reveals RSA1_5 in a couple of tests and in src/cryptojwt/jwt.py and src/cryptojwt/jwk/wrap.py .
We can replace i tests but changing jwt.py and wrap.py is trickier. That could easily be a breaking change.

@jschlyter is this intended to be closed or do we have to reopen until we fix what @rohe exposed in this thread?
Or instead open another Issue for that

@jschlyter
Copy link
Collaborator

@peppelinux I suggest we create a new issue for the general cleanup, ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants