feat(cd): adding dispatch workflow for cd #3765
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new GitHub Actions workflow to trigger deployment in a separate repository. The workflow responds to pushes on vnext and master branches or manual dispatch, and uses the GitHub API to send a repository dispatch event to the igniteui-actions repository.
Key Changes:
- New workflow file that triggers on push to
vnext/masterbranches and manual workflow dispatch - Uses GitHub API to send repository dispatch events with branch information and test configuration
- Configured with read-only content permissions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| curl -L \ | ||
| -X POST \ | ||
| -H "Accept: application/vnd.github+json" \ | ||
| -H "Authorization: Bearer ${{ secrets.FINE_PATKA }}" \ |
There was a problem hiding this comment.
The secret name 'FINE_PATKA' appears to be a typo. It should likely be 'FINE_PAT_KA' or 'FINE_GRAINED_PAT' based on standard naming conventions for fine-grained personal access tokens.
| -H "Authorization: Bearer ${{ secrets.FINE_PATKA }}" \ | |
| -H "Authorization: Bearer ${{ secrets.FINE_GRAINED_PAT }}" \ |
| repo_owner="IgniteUI" | ||
| repo_name="igniteui-actions" | ||
| event_type="igniteui-angular-samples-cd" | ||
| branch="${{ github.ref_name }}" |
There was a problem hiding this comment.
The workflow_dispatch input 'branch' is not being used. When triggered manually via workflow_dispatch, the branch variable should use github.event.inputs.branch instead of always using github.ref_name.
| branch="${{ github.ref_name }}" | |
| branch="${{ github.event.inputs.branch || github.ref_name }}" |
No description provided.