Fixing issues with opening the chart for the finjs sample #3769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the igniteui-angular-charts and igniteui-angular-core packages from version 19.x to 20.1.0, along with related code changes to support the upgrade. Additionally, it makes the Chart column in the grid conditionally visible and disables server-side rendering for all routes.
- Updated igniteui-angular-charts and igniteui-angular-core packages to version 20.1.0
- Replaced deprecated
IgxCategoryChartCoreModulewithIgxCategoryChartModule - Made the Chart column conditionally visible via
allowChartinput property
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated igniteui-angular-charts and igniteui-angular-core versions to 20.1.0 |
| package-lock.json | Updated lockfile with new package versions and peer dependency requirements |
| projects/app-lob/src/app/grid-finjs/main.component.ts | Replaced deprecated IgxCategoryChartCoreModule with IgxCategoryChartModule and fixed bug in setChartData where rowKey.id is now accessed |
| projects/app-lob/src/app/grid-finjs/main.component.html | Added allowChart input to enable Chart column |
| projects/app-lob/src/app/grid-finjs/grid-finjs.component.ts | Added allowChart input property to control Chart column visibility |
| projects/app-lob/src/app/grid-finjs/grid-finjs.component.html | Wrapped Chart column in @if conditional block using allowChart flag |
| projects/app-lob/src/app/app.routes.server.ts | Commented out specific client-side routes and changed default render mode from Prerender to Client for all routes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zdrawku
previously approved these changes
Nov 6, 2025
Contributor
|
Issues with missing chart and broken Pivot routing, fixed: 
|
zdrawku
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.