-
Notifications
You must be signed in to change notification settings - Fork 22
Fixing issues with opening the chart for the finjs sample #3769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
29acdf7
fix(finjs): making main chart sample work by upgrading charts
ChronosSF 2d77893
fix(partial-finjs): removing chart column for partial as it cannot work
ChronosSF 8c2b1c2
fix(*): update igniteui-angular-extras to version 20.0.2
dobromirts 714f367
chore(*): Fix broken Pivot samples routing
zdrawku e450e4a
chore(*): Fix missing chart in master detail
zdrawku File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,28 +1,28 @@ | ||
| import { RenderMode, ServerRoute } from '@angular/ssr'; | ||
|
|
||
| export const serverRoutes: ServerRoute[] = [ | ||
| { | ||
| path: 'grid/grid', | ||
| renderMode: RenderMode.Client // TODO: Fails with Prerender | ||
| }, | ||
| { | ||
| path: 'treegrid-finjs', | ||
| renderMode: RenderMode.Client // TODO: Fails with Prerender | ||
| }, | ||
| { | ||
| path: 'samples/treegrid-finjs', | ||
| renderMode: RenderMode.Client // TODO: Fails with Prerender | ||
| }, | ||
| { | ||
| path: 'grid-finjs-dock-manager/**', | ||
| renderMode: RenderMode.Client // TODO: Fails with Prerender | ||
| }, | ||
| { | ||
| path: 'samples/grid-finjs-dock-manager/**', | ||
| renderMode: RenderMode.Client // TODO: Fails with Prerender | ||
| }, | ||
| // { | ||
| // path: 'grid/grid', | ||
| // renderMode: RenderMode.Client // TODO: Fails with Prerender | ||
| // }, | ||
| // { | ||
| // path: 'treegrid-finjs', | ||
| // renderMode: RenderMode.Client // TODO: Fails with Prerender | ||
| // }, | ||
| // { | ||
| // path: 'samples/treegrid-finjs', | ||
| // renderMode: RenderMode.Client // TODO: Fails with Prerender | ||
| // }, | ||
| // { | ||
| // path: 'grid-finjs-dock-manager/**', | ||
| // renderMode: RenderMode.Client // TODO: Fails with Prerender | ||
| // }, | ||
| // { | ||
| // path: 'samples/grid-finjs-dock-manager/**', | ||
| // renderMode: RenderMode.Client // TODO: Fails with Prerender | ||
| // }, | ||
| { | ||
| path: '**', | ||
| renderMode: RenderMode.Prerender | ||
| renderMode: RenderMode.Client // SSR disabled for all routes | ||
| } | ||
| ]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 0 additions & 3 deletions
3
projects/app-lob/src/app/grid-dynamic-chart-data/grid-dynamic-chart-data.component.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 14 additions & 12 deletions
26
projects/app-lob/src/app/grid-finjs/grid-finjs.component.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
projects/app-lob/src/app/grid/grid-master-detail/grid-master-detail.component.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
projects/app-lob/src/app/pivot-grid/pivot-grid-routes-data.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| // tslint:disable:object-literal-sort-keys | ||
| export const pivotGridsRoutesData = { | ||
| 'pivot-grid-basic': { displayName: 'Basic Pivot Grid', parentName: 'Pivot Grid' }, | ||
| 'pivot-grid-datasource': { displayName: 'Pivot Grid With Datasource Component', parentName: 'Pivot Grid' }, | ||
| 'pivot-grid-noop': { displayName: 'Noop Pivot Grid', parentName: 'Pivot Grid' }, | ||
| 'pivot-grid-export': { displayName: 'Pivot Grid Export', parentName: 'Pivot Grid' }, | ||
| 'pivot-grid-features': { displayName: 'Pivot Grid With Features', parentName: 'Pivot Grid' }, | ||
| 'pivot-grid-state-persistence': { displayName: 'Pivot Grid With State Persistence', parentName: 'Pivot Grid' }, | ||
| 'pivot-grid-noop-persistence': { displayName: 'Pivot Noop Grid with State Persistence', parentName: 'Pivot Grid' }, | ||
| 'pivot-grid-about': { displayName: 'Pivot Grid About', parentName: 'Pivot Grid' }, | ||
| 'pivot-grid-layout': { displayName: 'Pivot Grid Layout', parentName: 'Pivot Grid' } | ||
| }; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.