Skip to content

Commit 07cfb82

Browse files
committed
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular into rkaraivanov/grids-spa-and-wellbeing
2 parents 7821e9e + f6f92c9 commit 07cfb82

File tree

4 files changed

+12
-13
lines changed

4 files changed

+12
-13
lines changed

projects/igniteui-angular/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@
8484
"web-animations-js": "^2.3.2"
8585
},
8686
"igxDevDependencies": {
87-
"@igniteui/angular-schematics": "~12.0.800-rc.0"
87+
"@igniteui/angular-schematics": "~12.0.800"
8888
},
8989
"ng-update": {
9090
"migrations": "./migrations/migration-collection.json"
Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,16 @@
11
<ng-container *ngIf="!asMenuItem">
2+
<button igxButton="icon" igxRipple (click)="handleClick($event)" (mousedown)="preventEvent($event)">
3+
<igx-icon *ngIf="iconSet" [family]="iconSet" [name]="iconName">{{iconName}}</igx-icon>
4+
<igx-icon *ngIf="!iconSet" >{{iconName}}</igx-icon>
5+
</button>
6+
</ng-container>
27

3-
<ng-container *ngIf="!asMenuItem">
4-
<button igxButton="icon" igxRipple (click)="handleClick($event)" (mousedown)="preventEvent($event)">
5-
<igx-icon *ngIf="iconSet" [family]="iconSet" [name]="iconName">{{iconName}}</igx-icon>
6-
<igx-icon *ngIf="!iconSet" >{{iconName}}</igx-icon>
7-
</button>
8-
</ng-container>
9-
8+
<ng-template #menuItemTemplate>
109
<ng-container *ngIf="asMenuItem">
1110
<div #container [className]='containerClass'>
1211
<igx-icon *ngIf="iconSet" [family]="iconSet" [name]="iconName">{{iconName}}</igx-icon>
1312
<igx-icon *ngIf="!iconSet" >{{iconName}}</igx-icon>
14-
<label *ngIf='asMenuItem' igxLabel>{{labelText}}</label>
13+
<label igxLabel>{{labelText}}</label>
1514
</div>
1615
</ng-container>
17-
</ng-container>
16+
</ng-template>

projects/igniteui-angular/src/lib/action-strip/grid-actions/grid-action-button.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export class IgxGridActionButtonComponent {
2626
* @hidden
2727
* @internal
2828
*/
29-
@ViewChild(TemplateRef)
29+
@ViewChild('menuItemTemplate')
3030
public templateRef: TemplateRef<any>;
3131

3232
/**

projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -661,8 +661,8 @@ export class IgxTreeGridComponent extends IgxGridBaseDirective implements GridTy
661661
* @param index
662662
*/
663663
public getRowByKey(key: any): RowType {
664-
const rec = this.primaryKey ? this.filteredSortedData.find(r => r[this.primaryKey] === key) :
665-
this.filteredSortedData.find(r => r === key);
664+
const rec = this.filteredSortedData ? this.primaryKey ? this.filteredSortedData.find(r => r[this.primaryKey] === key) :
665+
this.filteredSortedData.find(r => r === key) : undefined;
666666
const index = this.dataView.findIndex(r => r.data && r.data === rec);
667667
if (index < 0 || index >= this.filteredSortedData.length) {
668668
return undefined;

0 commit comments

Comments
 (0)