fix(icon): Requested changes applied #4971

Author: sboykova

projects/igniteui-angular/src/lib/icon/icon.service.spec.ts

@@ -1,6 +1,5 @@
 import { TestBed } from '@angular/core/testing';
 import { IgxIconService } from './icon.service';
-import { HttpClientTestingModule } from '@angular/common/http/testing';
 import { DOCUMENT } from '@angular/common';
 
 import { configureTestSuite } from '../test-utils/configure-suite';
@@ -17,7 +16,6 @@ describe('Icon Service', () => {
 
     beforeEach(() => {
         TestBed.configureTestingModule({
-            imports: [HttpClientTestingModule],
             providers: [IgxIconService]
         }).compileComponents();
     });
@@ -60,7 +58,7 @@ describe('Icon Service', () => {
         const fontSet = 'svg-icons';
         const iconKey = fontSet + '_' + iconName;
 
-        spyOn(XMLHttpRequest.prototype, 'open').and.callThrough(); // Jasmine 2.x
+        spyOn(XMLHttpRequest.prototype, 'open').and.callThrough();
         spyOn(XMLHttpRequest.prototype, 'send');
 
         iconService.addSvgIcon(iconName, 'test.svg', fontSet);

projects/igniteui-angular/src/lib/icon/icon.service.ts

@@ -134,17 +134,25 @@ export class IgxIconService {
     private fetchSvg(iconName: string, url: string, fontSet: string = '') {
         const instance = this;
         const httpRequest = new XMLHttpRequest();
+        httpRequest.open('GET', url, true);
+        httpRequest.responseType = 'text';
+
+        // load – when the result is ready, that includes HTTP errors like 404.
         httpRequest.onload = function (event: ProgressEvent) {
             const request = event.target as XMLHttpRequest;
             if (request.status === 200) {
                 instance.cacheSvgIcon(iconName, request.responseText, fontSet);
             } else {
-                throw new Error(`Could not fetch SVG from url: ${url}; error: ${request.status}`);
+                throw new Error(`Could not fetch SVG from url: ${url}; error: ${request.status} (${request.statusText})`);
             }
         };
 
-        httpRequest.open('GET', url, true);
-        httpRequest.responseType = 'text';
+        // error – when the request couldn’t be made, e.g.network down or invalid URL.
+        httpRequest.onerror = function (event: ProgressEvent) {
+            const request = event.target as XMLHttpRequest;
+            throw new Error(`Could not fetch SVG from url: ${url}; error status code: ${request.status} (${request.statusText})`);
+        };
+
         httpRequest.send();
     }