Skip to content

Commit 22b98d9

Browse files
committed
feat(tabs): fixing selection indicator visibility #4297
1 parent eb91831 commit 22b98d9

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

projects/igniteui-angular/src/lib/tabs/tab-item.component.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ export class IgxTabItemComponent implements IgxTabItemBase {
100100
@HostListener('window:resize', ['$event'])
101101
public onResize(event) {
102102
if (this.isSelected) {
103+
this._tabs.selectedIndicator.nativeElement.style.visibility = 'visible';
103104
this._tabs.selectedIndicator.nativeElement.style.width = `${this.nativeTabItem.nativeElement.offsetWidth}px`;
104105
this._tabs.selectedIndicator.nativeElement.style.transform = `translate(${this.nativeTabItem.nativeElement.offsetLeft}px)`;
105106
}
@@ -235,6 +236,7 @@ export class IgxTabItemComponent implements IgxTabItemBase {
235236
}
236237

237238
private transformIndicatorAnimation(element: HTMLElement): void {
239+
this._tabs.selectedIndicator.nativeElement.style.visibility = `visible`;
238240
this._tabs.selectedIndicator.nativeElement.style.width = `${element.offsetWidth}px`;
239241
this._tabs.selectedIndicator.nativeElement.style.transform = `translate(${element.offsetLeft}px)`;
240242
}

projects/igniteui-angular/src/lib/tabs/tabs.component.ts

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ export class IgxTabsComponent implements IgxTabsBase, AfterViewInit, OnDestroy {
207207
public offset = 0;
208208

209209
private _groupChanges$: Subscription;
210-
private _selectedIndex = 0;
210+
private _selectedIndex = -1;
211211

212212
/**
213213
* @hidden
@@ -331,13 +331,16 @@ export class IgxTabsComponent implements IgxTabsBase, AfterViewInit, OnDestroy {
331331

332332
private setSelectedGroup(): void {
333333
requestAnimationFrame(() => {
334-
if (this.selectedIndex <= 0 || this.selectedIndex >= this.groups.length) {
335-
// if nothing is selected - select the first tabs group
336-
if (!this.hasContentTabs) {
337-
this.selectGroupByIndex(0);
334+
if (this.hasContentTabs) {
335+
if (this.selectedIndex < 0 || this.selectedIndex >= this.contentTabs.length) {
336+
this.selectedIndicator.nativeElement.style.visibility = 'hidden';
338337
}
339338
} else {
340-
this.selectGroupByIndex(this.selectedIndex);
339+
if (this.selectedIndex <= 0 || this.selectedIndex >= this.groups.length) {
340+
this.selectGroupByIndex(0);
341+
} else {
342+
this.selectGroupByIndex(this.selectedIndex);
343+
}
341344
}
342345
});
343346
}

0 commit comments

Comments
 (0)