Skip to content

Commit 27a0b5d

Browse files
committed
chore(combo): add comment to incorrect combo tests
1 parent 32329e9 commit 27a0b5d

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

projects/igniteui-angular/src/lib/combo/combo.component.spec.ts

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1046,6 +1046,10 @@ describe('igxCombo', () => {
10461046
const combo = fix.componentInstance.combo;
10471047
spyOn(combo.onSelectionChange, 'emit');
10481048
let oldSelection = [];
1049+
/**
1050+
* The test component has a defined `valueKey` property.
1051+
* `selectItems` method should be called with the items' corresponding valueKeys
1052+
*/
10491053
let newSelection = [combo.data[1], combo.data[5], combo.data[6]];
10501054
let newSelectionKeys = newSelection.map(entry => entry[combo.valueKey]);
10511055

@@ -3454,7 +3458,12 @@ class IgxComboScrollTestComponent {
34543458
`
34553459
})
34563460
class IgxComboSampleComponent {
3457-
3461+
/**
3462+
* TODO
3463+
* Test that use this component should properly call `selectItems` method
3464+
* IF a `valueKey` is defined, calls should be w/ the items' valueKey property value
3465+
* IF no `valueKey` is defined, calls should be w/ object references to the items
3466+
*/
34583467
@ViewChild('combo', { read: IgxComboComponent, static: true })
34593468
public combo: IgxComboComponent;
34603469

0 commit comments

Comments
 (0)