Skip to content

Commit 40cd8c6

Browse files
authored
chore(*): dependency updates (#8980)
* ci(*): updating @angular/cli, @angular/core and other dependencies Clean up code style in spec files
1 parent 308f045 commit 40cd8c6

12 files changed

+1242
-1493
lines changed

package-lock.json

Lines changed: 1130 additions & 1375 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -46,22 +46,22 @@
4646
},
4747
"private": true,
4848
"dependencies": {
49-
"@angular/animations": "^11.1.0",
50-
"@angular/common": "^11.1.0",
51-
"@angular/compiler": "^11.1.0",
52-
"@angular/core": "^11.1.0",
53-
"@angular/forms": "^11.1.0",
54-
"@angular/platform-browser": "^11.1.0",
55-
"@angular/platform-browser-dynamic": "^11.1.0",
56-
"@angular/router": "^11.1.0",
49+
"@angular/animations": "^11.2.0",
50+
"@angular/common": "^11.2.0",
51+
"@angular/compiler": "^11.2.0",
52+
"@angular/core": "^11.2.0",
53+
"@angular/forms": "^11.2.0",
54+
"@angular/platform-browser": "^11.2.0",
55+
"@angular/platform-browser-dynamic": "^11.2.0",
56+
"@angular/router": "^11.2.0",
5757
"@igniteui/material-icons-extended": "^2.4.0",
5858
"@types/hammerjs": "^2.0.36",
5959
"@types/source-map": "0.5.2",
6060
"classlist.js": "^1.1.20150312",
6161
"core-js": "^2.6.11",
6262
"hammerjs": "^2.0.8",
6363
"igniteui-trial-watermark": "^1.0.3",
64-
"jszip": "^3.5.0",
64+
"jszip": "^3.6.0",
6565
"lodash.mergewith": "^4.6.2",
6666
"resize-observer-polyfill": "^1.5.1",
6767
"rxjs": "^6.6.3",
@@ -72,27 +72,27 @@
7272
"zone.js": "~0.10.3"
7373
},
7474
"devDependencies": {
75-
"@angular-devkit/build-angular": "~0.1101.1",
76-
"@angular-devkit/schematics": "^11.1.1",
75+
"@angular-devkit/build-angular": "~0.1102.0",
76+
"@angular-devkit/schematics": "^11.2.0",
7777
"@angular-eslint/builder": "1.1.0",
7878
"@angular-eslint/eslint-plugin": "1.1.0",
7979
"@angular-eslint/eslint-plugin-template": "1.1.0",
80-
"@angular-eslint/schematics": "^1.1.0",
80+
"@angular-eslint/schematics": "^1.2.0",
8181
"@angular-eslint/template-parser": "1.1.0",
82-
"@angular/cli": "~11.1.1",
83-
"@angular/compiler-cli": "^11.1.0",
84-
"@angular/language-service": "^11.1.0",
82+
"@angular/cli": "~11.2.0",
83+
"@angular/compiler-cli": "^11.2.0",
84+
"@angular/language-service": "^11.2.0",
8585
"@angularclass/hmr": "^2.1.3",
8686
"@types/jasmine": "^3.3.16",
8787
"@types/jasminewd2": "^2.0.8",
88-
"@types/node": "^12.12.39",
88+
"@types/node": "^12.20.0",
8989
"@types/webpack-env": "^1.15.2",
9090
"@typescript-eslint/eslint-plugin": "4.3.0",
9191
"@typescript-eslint/parser": "4.3.0",
9292
"browser-sync": "^2.26.12",
9393
"codelyzer": "^6.0.0",
9494
"coveralls": "^3.1.0",
95-
"eslint": "^7.6.0",
95+
"eslint": "^7.20.0",
9696
"eslint-plugin-import": "2.22.1",
9797
"eslint-plugin-jsdoc": "30.7.6",
9898
"eslint-plugin-prefer-arrow": "1.2.2",
@@ -121,20 +121,20 @@
121121
"karma-junit-reporter": "~2.0.1",
122122
"karma-spec-reporter": "~0.0.32",
123123
"lunr": "^2.3.8",
124-
"ng-packagr": "^11.0.3",
124+
"ng-packagr": "^11.2.1",
125125
"pngcrush": "^2.0.1",
126126
"protractor": "~7.0.0",
127127
"sass-true": "^5.0.0",
128128
"sassdoc": "^2.7.3",
129129
"sassdoc-plugin-localization": "^1.4.1",
130-
"stylelint": "^11.1.1",
131-
"stylelint-scss": "^3.17.2",
130+
"stylelint": "^13.10.0",
131+
"stylelint-scss": "^3.19.0",
132132
"themeleon": "^3.0.2",
133133
"ts-node": "~7.0.1",
134134
"tslint": "~6.1.0",
135135
"typedoc": "^0.17.7",
136136
"typedoc-plugin-localization": "^2.2.1",
137-
"typescript": "~4.0.2",
137+
"typescript": "^4.0.7",
138138
"webpack-sources": "1.3.0"
139139
}
140140
}

projects/igniteui-angular/src/lib/grids/grid/column-group.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1598,7 +1598,7 @@ const testColumnPinning = (column: IgxColumnComponent, isPinned: boolean) => {
15981598
type PinUnpinFunc = (component: ColumnGroupFourLevelTestComponent) => void;
15991599

16001600
class PinningTests {
1601-
static testColumnGroupPinning(pinGenInfoColFunc: PinUnpinFunc, unpinGenInfoColFunc: PinUnpinFunc) {
1601+
public static testColumnGroupPinning(pinGenInfoColFunc: PinUnpinFunc, unpinGenInfoColFunc: PinUnpinFunc) {
16021602
const fixture = TestBed.createComponent(ColumnGroupFourLevelTestComponent);
16031603
fixture.detectChanges();
16041604
const ci = fixture.componentInstance;
@@ -1634,7 +1634,7 @@ class PinningTests {
16341634
}
16351635

16361636
class NestedColGroupsTests {
1637-
static testHeadersRendering(fixture: ComponentFixture<NestedColumnGroupsGridComponent>) {
1637+
public static testHeadersRendering(fixture: ComponentFixture<NestedColumnGroupsGridComponent>) {
16381638
const ci = fixture.componentInstance;
16391639
const grid = ci.grid;
16401640
const firstSlaveColGroup = fixture.debugElement.query(By.css('.firstSlaveColGroup'));

projects/igniteui-angular/src/lib/grids/grid/column-hiding.spec.ts

Lines changed: 36 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import { configureTestSuite } from '../../test-utils/configure-suite';
1212
import { GridSelectionMode, ColumnDisplayOrder } from '../common/enums';
1313
import { ControlsFunction } from '../../test-utils/controls-functions.spec';
1414
import { IgxColumnActionsComponent } from '../column-actions/column-actions.component';
15-
import { IColumnVisibilityChangingEventArgs } from '../common/events';
1615

1716
describe('Column Hiding UI #grid', () => {
1817
configureTestSuite();
@@ -148,7 +147,7 @@ describe('Column Hiding UI #grid', () => {
148147
grid.columns[3].disableHiding = undefined;
149148
fix.detectChanges();
150149

151-
verifyCheckbox('Released', true, false, columnChooserElement, fix);
150+
verifyCheckbox('Released', true, false, columnChooserElement);
152151
});
153152

154153
it('onColumnToggled, onColumnVisibilityChanged, onColumnVisibilityChanging event is fired on toggling checkboxes.', () => {
@@ -201,7 +200,7 @@ describe('Column Hiding UI #grid', () => {
201200

202201
it('- toggling column checkbox checked state successfully changes the grid column visibility.', () => {
203202
const checkbox = GridFunctions.getColumnChooserItemElement(columnChooserElement, 'ReleaseDate');
204-
verifyCheckbox('ReleaseDate', true, false, columnChooserElement, fix);
203+
verifyCheckbox('ReleaseDate', true, false, columnChooserElement);
205204

206205
const column = grid.getColumnByName('ReleaseDate');
207206
verifyColumnIsHidden(column, false, 4);
@@ -222,25 +221,25 @@ describe('Column Hiding UI #grid', () => {
222221
spyOn(grid.columnVisibilityChanging, 'emit');
223222

224223
const name = 'ReleaseDate';
225-
verifyCheckbox(name, true, false, columnChooserElement, fix);
224+
verifyCheckbox(name, true, false, columnChooserElement);
226225
const column = grid.getColumnByName(name);
227226

228227
column.hidden = true;
229228
fix.detectChanges();
230229

231-
verifyCheckbox(name, false, false, columnChooserElement, fix);
230+
verifyCheckbox(name, false, false, columnChooserElement);
232231
verifyColumnIsHidden(column, true, 3);
233232

234233
column.hidden = false;
235234
fix.detectChanges();
236235

237-
verifyCheckbox(name, true, false, columnChooserElement, fix);
236+
verifyCheckbox(name, true, false, columnChooserElement);
238237
verifyColumnIsHidden(column, false, 4);
239238

240239
column.hidden = undefined;
241240
fix.detectChanges();
242241

243-
verifyCheckbox(name, true, false, columnChooserElement, fix);
242+
verifyCheckbox(name, true, false, columnChooserElement);
244243
verifyColumnIsHidden(column, undefined, 4);
245244

246245
column.hidden = true;
@@ -250,7 +249,7 @@ describe('Column Hiding UI #grid', () => {
250249
column.hidden = null;
251250
fix.detectChanges();
252251

253-
verifyCheckbox(name, true, false, columnChooserElement, fix);
252+
verifyCheckbox(name, true, false, columnChooserElement);
254253
verifyColumnIsHidden(column, null, 4);
255254
expect(grid.columnVisibilityChanging.emit).toHaveBeenCalledTimes(0);
256255
expect(grid.onColumnVisibilityChanged.emit).toHaveBeenCalledTimes(0);
@@ -265,7 +264,7 @@ describe('Column Hiding UI #grid', () => {
265264
const hideAll = GridFunctions.getColumnChooserButton(columnChooserElement, 'Hide All').nativeElement;
266265

267266
const checkbox = GridFunctions.getColumnChooserItemElement(columnChooserElement, name);
268-
verifyCheckbox(name, false, false, columnChooserElement, fix);
267+
verifyCheckbox(name, false, false, columnChooserElement);
269268
ControlsFunction.verifyButtonIsDisabled(showAll, false);
270269
ControlsFunction.verifyButtonIsDisabled(hideAll);
271270

@@ -294,7 +293,7 @@ describe('Column Hiding UI #grid', () => {
294293
const hideAll = GridFunctions.getColumnChooserButton(columnChooserElement, 'Hide All').nativeElement;
295294

296295
const checkbox = GridFunctions.getColumnChooserItemElement(columnChooserElement, name);
297-
verifyCheckbox(name, true, false, columnChooserElement, fix);
296+
verifyCheckbox(name, true, false, columnChooserElement);
298297
ControlsFunction.verifyButtonIsDisabled(showAll);
299298
ControlsFunction.verifyButtonIsDisabled(hideAll, false);
300299

@@ -722,16 +721,16 @@ describe('Column Hiding UI #grid', () => {
722721
GridFunctions.clickColumnChooserItem(columnChooserElement, 'Person Details');
723722
fix.detectChanges();
724723

725-
verifyCheckbox('Person Details', false, false, columnChooserElement, fix);
726-
verifyCheckbox('ContactName', false, false, columnChooserElement, fix);
727-
verifyCheckbox('ContactTitle', false, false, columnChooserElement, fix);
724+
verifyCheckbox('Person Details', false, false, columnChooserElement);
725+
verifyCheckbox('ContactName', false, false, columnChooserElement);
726+
verifyCheckbox('ContactTitle', false, false, columnChooserElement);
728727

729728
verifyColumnIsHidden(grid.columns[3], true, 4);
730729
verifyColumnIsHidden(grid.columns[4], true, 4);
731730
verifyColumnIsHidden(grid.columns[5], true, 4);
732731

733-
verifyCheckbox('CompanyName', true, false, columnChooserElement, fix);
734-
verifyCheckbox('General Information', true, false, columnChooserElement, fix);
732+
verifyCheckbox('CompanyName', true, false, columnChooserElement);
733+
verifyCheckbox('General Information', true, false, columnChooserElement);
735734

736735
GridFunctions.clickColumnChooserItem(columnChooserElement, 'Person Details');
737736
fix.detectChanges();
@@ -740,58 +739,58 @@ describe('Column Hiding UI #grid', () => {
740739
verifyColumnIsHidden(grid.columns[4], false, 7);
741740
verifyColumnIsHidden(grid.columns[5], false, 7);
742741

743-
verifyCheckbox('Person Details', true, false, columnChooserElement, fix);
744-
verifyCheckbox('ContactName', true, false, columnChooserElement, fix);
745-
verifyCheckbox('ContactTitle', true, false, columnChooserElement, fix);
742+
verifyCheckbox('Person Details', true, false, columnChooserElement);
743+
verifyCheckbox('ContactName', true, false, columnChooserElement);
744+
verifyCheckbox('ContactTitle', true, false, columnChooserElement);
746745

747-
verifyCheckbox('CompanyName', true, false, columnChooserElement, fix);
748-
verifyCheckbox('General Information', true, false, columnChooserElement, fix);
746+
verifyCheckbox('CompanyName', true, false, columnChooserElement);
747+
verifyCheckbox('General Information', true, false, columnChooserElement);
749748
});
750749

751750
it('checks & hides all descendants when hiding top level parent.', () => {
752751
GridFunctions.clickColumnChooserItem(columnChooserElement, 'General Information');
753752
fix.detectChanges();
754753

755-
verifyCheckbox('General Information', false, false, columnChooserElement, fix);
756-
verifyCheckbox('CompanyName', false, false, columnChooserElement, fix);
754+
verifyCheckbox('General Information', false, false, columnChooserElement);
755+
verifyCheckbox('CompanyName', false, false, columnChooserElement);
757756

758-
verifyCheckbox('Person Details', false, false, columnChooserElement, fix);
759-
verifyCheckbox('ContactName', false, false, columnChooserElement, fix);
760-
verifyCheckbox('ContactTitle', false, false, columnChooserElement, fix);
757+
verifyCheckbox('Person Details', false, false, columnChooserElement);
758+
verifyCheckbox('ContactName', false, false, columnChooserElement);
759+
verifyCheckbox('ContactTitle', false, false, columnChooserElement);
761760

762-
verifyCheckbox('Missing', true, false, columnChooserElement, fix);
763-
verifyCheckbox('ID', true, false, columnChooserElement, fix);
761+
verifyCheckbox('Missing', true, false, columnChooserElement);
762+
verifyCheckbox('ID', true, false, columnChooserElement);
764763

765764
GridFunctions.clickColumnChooserItem(columnChooserElement, 'General Information');
766765
fix.detectChanges();
767766

768-
verifyCheckbox('General Information', true, false, columnChooserElement, fix);
769-
verifyCheckbox('CompanyName', true, false, columnChooserElement, fix);
767+
verifyCheckbox('General Information', true, false, columnChooserElement);
768+
verifyCheckbox('CompanyName', true, false, columnChooserElement);
770769

771-
verifyCheckbox('Person Details', true, false, columnChooserElement, fix);
772-
verifyCheckbox('ContactName', true, false, columnChooserElement, fix);
773-
verifyCheckbox('ContactTitle', true, false, columnChooserElement, fix);
770+
verifyCheckbox('Person Details', true, false, columnChooserElement);
771+
verifyCheckbox('ContactName', true, false, columnChooserElement);
772+
verifyCheckbox('ContactTitle', true, false, columnChooserElement);
774773
});
775774

776775
it('checks/unchecks parent when all children are checked/unchecked.', () => {
777-
verifyCheckbox('Person Details', true, false, columnChooserElement, fix);
776+
verifyCheckbox('Person Details', true, false, columnChooserElement);
778777
GridFunctions.clickColumnChooserItem(columnChooserElement, 'ContactName');
779778
fix.detectChanges();
780779

781-
verifyCheckbox('Person Details', true, false, columnChooserElement, fix);
780+
verifyCheckbox('Person Details', true, false, columnChooserElement);
782781
GridFunctions.clickColumnChooserItem(columnChooserElement, 'ContactTitle');
783782
fix.detectChanges();
784783

785-
verifyCheckbox('Person Details', false, false, columnChooserElement, fix);
784+
verifyCheckbox('Person Details', false, false, columnChooserElement);
786785
GridFunctions.clickColumnChooserItem(columnChooserElement, 'ContactName');
787786
fix.detectChanges();
788787

789-
verifyCheckbox('Person Details', true, false, columnChooserElement, fix);
788+
verifyCheckbox('Person Details', true, false, columnChooserElement);
790789

791790
GridFunctions.clickColumnChooserItem(columnChooserElement, 'ContactTitle');
792791
fix.detectChanges();
793792

794-
verifyCheckbox('Person Details', true, false, columnChooserElement, fix);
793+
verifyCheckbox('Person Details', true, false, columnChooserElement);
795794
});
796795

797796
it('filters group columns properly.', () => {

projects/igniteui-angular/src/lib/grids/grid/column-pinning.spec.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ describe('Column Pinning UI #grid', () => {
9494

9595
it(`- toggling column checkbox checked state successfully changes the column's pinned state.`, () => {
9696
const checkbox = GridFunctions.getColumnChooserItemElement(columnChooserElement, 'ReleaseDate');
97-
verifyCheckbox('ReleaseDate', false, false, columnChooserElement, fix);
97+
verifyCheckbox('ReleaseDate', false, false, columnChooserElement);
9898

9999
const column = grid.getColumnByName('ReleaseDate');
100100
verifyColumnIsPinned(column, false, 0);
@@ -135,25 +135,25 @@ describe('Column Pinning UI #grid', () => {
135135

136136
it('reflects properly grid column pinned value changes.', () => {
137137
const name = 'ReleaseDate';
138-
verifyCheckbox(name, false, false, columnChooserElement, fix);
138+
verifyCheckbox(name, false, false, columnChooserElement);
139139
const column = grid.getColumnByName(name);
140140

141141
column.pinned = true;
142142
fix.detectChanges();
143143

144-
verifyCheckbox(name, true, false, columnChooserElement, fix);
144+
verifyCheckbox(name, true, false, columnChooserElement);
145145
verifyColumnIsPinned(column, true, 1);
146146

147147
column.pinned = false;
148148
fix.detectChanges();
149149

150-
verifyCheckbox(name, false, false, columnChooserElement, fix);
150+
verifyCheckbox(name, false, false, columnChooserElement);
151151
verifyColumnIsPinned(column, false, 0);
152152

153153
column.pinned = undefined;
154154
fix.detectChanges();
155155

156-
verifyCheckbox(name, false, false, columnChooserElement, fix);
156+
verifyCheckbox(name, false, false, columnChooserElement);
157157
verifyColumnIsPinned(column, false, 0);
158158

159159
column.pinned = true;
@@ -163,7 +163,7 @@ describe('Column Pinning UI #grid', () => {
163163
column.pinned = null;
164164
fix.detectChanges();
165165

166-
verifyCheckbox(name, false, false, columnChooserElement, fix);
166+
verifyCheckbox(name, false, false, columnChooserElement);
167167
verifyColumnIsPinned(column, false, 0);
168168
});
169169

@@ -332,7 +332,7 @@ describe('Column Pinning UI #grid', () => {
332332
GridFunctions.clickColumnChooserItem(columnChooserElement, columnName);
333333
fix.detectChanges();
334334

335-
verifyCheckbox(columnName, true, false, columnChooserElement, fix);
335+
verifyCheckbox(columnName, true, false, columnChooserElement);
336336
expect(grid.columns[1].allChildren.every((col) => col.pinned)).toBe(true);
337337
});
338338

@@ -342,12 +342,12 @@ describe('Column Pinning UI #grid', () => {
342342
grid.columns[1].pin();
343343
fix.detectChanges();
344344

345-
verifyCheckbox(columnName, true, false, columnChooserElement, fix);
345+
verifyCheckbox(columnName, true, false, columnChooserElement);
346346
expect(grid.columns[1].allChildren.every((col) => col.pinned)).toBe(true);
347347

348348
GridFunctions.clickColumnChooserItem(columnChooserElement, columnName);
349349
fix.detectChanges();
350-
verifyCheckbox(columnName, false, false, columnChooserElement, fix);
350+
verifyCheckbox(columnName, false, false, columnChooserElement);
351351
expect(grid.columns[1].allChildren.every((col) => !col.pinned)).toBe(true);
352352
});
353353
});

0 commit comments

Comments
 (0)