Skip to content

Commit 486b8fa

Browse files
committed
fix(themes): replace implode function with selector-append
The implode function didn't play nicely with the Dart Sass compiler. Use the built-in selector-append function in its place.
1 parent 1566d9a commit 486b8fa

File tree

2 files changed

+3
-24
lines changed

2 files changed

+3
-24
lines changed

projects/igniteui-angular/src/lib/core/styles/base/utilities/_bem.scss

+3-3
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ $bem--sep-mod-val: if(variable-exists(bem--sep-mod-val), $bem--sep-mod-val, '-')
236236
@content;
237237
}
238238
} @else {
239-
#{implode($mx)} {
239+
#{selector-append($mx...)} {
240240
@content;
241241
}
242242
}
@@ -253,7 +253,7 @@ $bem--sep-mod-val: if(variable-exists(bem--sep-mod-val), $bem--sep-mod-val, '-')
253253
@content;
254254
}
255255
} @else {
256-
#{$first} #{implode($mx)} {
256+
#{$first} #{selector-append($mx...)} {
257257
@content;
258258
}
259259
}
@@ -307,7 +307,7 @@ $bem--sep-mod-val: if(variable-exists(bem--sep-mod-val), $bem--sep-mod-val, '-')
307307
$mod-classes: append($mod-classes, #{bem-selector($block: $this, $m: $mod)})
308308
}
309309
@at-root {
310-
#{implode($mod-classes)} {
310+
#{selector-append($mod-classes...)} {
311311
@content;
312312
}
313313
}

projects/igniteui-angular/src/lib/core/styles/base/utilities/_functions.scss

-21
Original file line numberDiff line numberDiff line change
@@ -326,27 +326,6 @@
326326
);
327327
}
328328

329-
/// Returns a string from the elements of a list.
330-
/// Works recursively so the elements can be lists themselves.
331-
/// @param {List} $list [null] - A list of elements to be turned into a string.
332-
/// @param {String} $glue [''] - A string symbol to join the elements by.
333-
@function implode($list, $glue: '') {
334-
$result: null;
335-
@for $i from 1 through length($list) {
336-
$e: nth($list, $i);
337-
@if type-of($e) == list {
338-
$result: $result#{implode($e, $glue)};
339-
} @else {
340-
$result: if(
341-
$i != length($list),
342-
$result#{$e}#{$glue},
343-
$result#{$e}
344-
);
345-
}
346-
}
347-
@return $result;
348-
}
349-
350329
/// Returns a CSS property value. It could return either css '--var' or
351330
/// a plain string value based on theme configuration.
352331
/// @access public

0 commit comments

Comments
 (0)