Skip to content

Commit 502567a

Browse files
committed
fix(igxGrid): Column group hiding
Closes #488
1 parent 0b2c8ec commit 502567a

File tree

4 files changed

+16
-8
lines changed

4 files changed

+16
-8
lines changed

projects/igniteui-angular/src/lib/chips/chips.module.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { cloneArray } from '../core/utils';
55
import { IgxRippleModule } from '../directives/ripple/ripple.directive';
66
import { IgxButtonModule } from '../directives/button/button.directive';
77
import { IgxAvatarModule } from '../avatar/avatar.component';
8-
import { IgxIconModule } from '../icon';
8+
import { IgxIconModule } from '../icon/index';
99
import { IgxConnectorDirective } from './connector.directive';
1010
import { IgxChipComponent } from './chip.component';
1111
import { IgxChipsAreaComponent } from './chips-area.component';

projects/igniteui-angular/src/lib/grid/column.component.ts

+4-2
Original file line numberDiff line numberDiff line change
@@ -235,9 +235,11 @@ export class IgxColumnComponent implements AfterContentInit {
235235
get visibleIndex(): number {
236236
const grid = this.gridAPI.get(this.gridID);
237237
let vIndex = -1;
238+
238239
if (this.columnGroup) {
239240
return vIndex;
240241
}
242+
241243
if (!this.pinned) {
242244
const indexInCollection = grid.unpinnedColumns.indexOf(this);
243245
vIndex = indexInCollection === -1 ? -1 : grid.pinnedColumns.length + indexInCollection;
@@ -502,7 +504,7 @@ export class IgxColumnGroupComponent extends IgxColumnComponent implements After
502504

503505
@Input()
504506
get hidden() {
505-
return this._hidden;
507+
return this.allChildren.every(c => c.hidden);
506508
}
507509

508510
set hidden(value: boolean) {
@@ -537,8 +539,8 @@ export class IgxColumnGroupComponent extends IgxColumnComponent implements After
537539
}
538540

539541

540-
function flatten(arr: any[]) {
541542

543+
function flatten(arr: any[]) {
542544
let result = [];
543545

544546
arr.forEach(el => {

src/app/drop-down/drop-down.sample.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22
<app-page-header title="Dropdown menu" description="description for dropdown menu"></app-page-header>
33
<section class="sample-content">
44
<button #button igxButton="raised" igxRipple (click)="toggleDropDown()">Toggle</button>
5-
<igx-drop-down (onSelection)="onSelection($event)" (onOpening)="onOpening($event)">
5+
<igx-drop-down (onSelection)="onSelection()" (onOpening)="onOpening()">
66
<igx-drop-down-item *ngFor="let item of items" disabled={{item.disabled}} isHeader={{item.header}}>
77
<div class="igx-drop-down__item-template">
88
{{ item.field }}
99
</div>
1010
</igx-drop-down-item>
1111
</igx-drop-down>
1212
</section>
13-
</div>
13+
</div>

src/app/grid-column-groups/grid-column-groups.sample.ts

+9-3
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
import { Component, ViewChild } from '@angular/core';
1+
import { Component, ViewChild, AfterViewInit } from '@angular/core';
22
import { IgxGridComponent } from 'igniteui-angular';
33

44
@Component({
55
selector: 'app-grid-column-groups-sample',
66
templateUrl: 'grid-column-groups.sample.html'
77
})
8-
export class GridColumnGroupsSampleComponent {
8+
export class GridColumnGroupsSampleComponent implements AfterViewInit {
99

1010
@ViewChild('grid', { read: IgxGridComponent })
1111
grid: IgxGridComponent;
@@ -43,12 +43,18 @@ export class GridColumnGroupsSampleComponent {
4343
// tslint:enable:max-line-length
4444

4545
pinGroup() {
46-
const t = this.grid.getColumnByName('ID');
46+
const t = this.grid.getColumnByName('ContactTitle');
4747
t.pinned = !t.pinned;
4848
}
4949

5050
hideGroup() {
5151
const col = this.grid.columnList.filter(c => c.header === 'Person Details')[0];
5252
col.hidden = !col.hidden;
53+
this.grid.getColumnByName('CompanyName').hidden = true;
54+
console.log(this.grid.getColumnByName('CompanyName').parent);
55+
}
56+
57+
ngAfterViewInit() {
58+
// this.grid.groupBy({ fieldName: 'Country', dir: 1, ignoreCase: false });
5359
}
5460
}

0 commit comments

Comments
 (0)