feat(adv-filtering): fix condition select target setting #5496

Author: DiyanDimitrov

projects/igniteui-angular/src/lib/grids/filtering/advanced-filtering/advanced-filtering-dialog.component.html

@@ -156,6 +156,7 @@ <h6 class="igx-filter-empty__title">
                                 type="box"
                                 [displayDensity]="'compact'"
                                 [overlaySettings]="conditionSelectOverlaySettings"
+                                (onOpening)="onConditionSelectOpening()"
                                 [placeholder]="grid.resourceStrings.igx_grid_filter_condition_placeholder"
                                 [(ngModel)]="selectedCondition"
                                 [disabled]="!selectedColumn">

projects/igniteui-angular/src/lib/grids/filtering/advanced-filtering/advanced-filtering-dialog.component.ts

@@ -124,17 +124,7 @@ export class IgxAdvancedFilteringDialogComponent implements AfterViewInit, OnDes
     public columnSelect: IgxSelectComponent;
 
     @ViewChild('conditionSelect', { read: IgxSelectComponent, static: false })
-    public set conditionSelect(value: IgxSelectComponent) {
-        if ((value && !this._conditionSelect) ||
-            (value && this._conditionSelect && this._conditionSelect.element !== value.element)) {
-            this.conditionSelectOverlaySettings.positionStrategy.settings.target = value.element;
-        }
-        this._conditionSelect = value;
-    }
-
-    public get conditionSelect() {
-        return this._conditionSelect;
-    }
+    public conditionSelect: IgxSelectComponent;
 
     @ViewChild('searchValueInput', { read: ElementRef, static: false })
     public searchValueInput: ElementRef;
@@ -213,7 +203,6 @@ export class IgxAdvancedFilteringDialogComponent implements AfterViewInit, OnDes
     private _clickTimer;
     private _dblClickDelay = 200;
     private _preventChipClick = false;
-    private _conditionSelect: IgxSelectComponent;
     private _editingInputsContainer: ElementRef;
     private _addModeContainer: ElementRef;
     private _currentGroupButtonsContainer: ElementRef;
@@ -787,6 +776,10 @@ export class IgxAdvancedFilteringDialogComponent implements AfterViewInit, OnDes
         event.preventDefault();
     }
 
+    public onConditionSelectOpening() {
+        this.conditionSelectOverlaySettings.positionStrategy.settings.target = this.conditionSelect.element;
+    }
+
     public initialize(filteringService: IgxFilteringService, overlayService: IgxOverlayService,
         overlayComponentId: string) {
         this.filteringService = filteringService;