Skip to content

Commit 7c9ca7e

Browse files
committed
feat(adv-filtering): update API comments #5496
1 parent acd612f commit 7c9ca7e

File tree

2 files changed

+20
-6
lines changed

2 files changed

+20
-6
lines changed

projects/igniteui-angular/src/lib/grids/filtering/advanced-filtering/advanced-filtering-dialog.component.ts

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import { IgxOverlayService } from '../../../services/overlay/overlay';
88
import { IgxGridBaseComponent, IgxColumnComponent } from '../../grid';
99
import { FilteringExpressionsTree, IFilteringExpressionsTree } from '../../../data-operations/filtering-expressions-tree';
1010
import { FilteringLogic, IFilteringExpression } from '../../../data-operations/filtering-expression.interface';
11-
import { IgxStringFilteringOperand } from '../../../data-operations/filtering-condition';
1211
import { IgxChipComponent } from '../../../chips/chip.component';
1312
import { IgxSelectComponent } from '../../../select/select.component';
1413
import { IDragStartEventArgs, IDragBaseEventArgs } from '../../../directives/drag-drop/drag-drop.directive';
@@ -19,6 +18,9 @@ import { takeUntil, first } from 'rxjs/operators';
1918
import { Subject } from 'rxjs';
2019
import { KEYS } from '../../../core/utils';
2120

21+
/**
22+
*@hidden
23+
*/
2224
class ExpressionItem {
2325
constructor(parent?: ExpressionGroupItem) {
2426
this.parent = parent;
@@ -27,6 +29,9 @@ class ExpressionItem {
2729
selected: boolean;
2830
}
2931

32+
/**
33+
*@hidden
34+
*/
3035
class ExpressionGroupItem extends ExpressionItem {
3136
constructor(operator: FilteringLogic, parent?: ExpressionGroupItem) {
3237
super(parent);
@@ -37,6 +42,9 @@ class ExpressionGroupItem extends ExpressionItem {
3742
children: ExpressionItem[];
3843
}
3944

45+
/**
46+
*@hidden
47+
*/
4048
class ExpressionOperandItem extends ExpressionItem {
4149
constructor(expression: IFilteringExpression, parent: ExpressionGroupItem) {
4250
super(parent);
@@ -48,9 +56,10 @@ class ExpressionOperandItem extends ExpressionItem {
4856
hovered: boolean;
4957
}
5058

59+
/**
60+
* @hidden
61+
*/
5162
@Component({
52-
// changeDetection: ChangeDetectionStrategy.OnPush,
53-
// preserveWhitespaces: false,
5463
selector: 'igx-advanced-filtering-dialog',
5564
templateUrl: './advanced-filtering-dialog.component.html'
5665
})

projects/igniteui-angular/src/lib/grids/grid-base.component.ts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -405,7 +405,7 @@ export abstract class IgxGridBaseComponent extends DisplayDensityBase implements
405405
}
406406

407407
/**
408-
* Returns the cross-field filtering state of `IgxGridComponent`.
408+
* Returns the advanced filtering state of `IgxGridComponent`.
409409
* ```typescript
410410
* let advancedFilteringExpressionsTree = this.grid.advancedFilteringExpressionsTree;
411411
* ```
@@ -418,14 +418,19 @@ export abstract class IgxGridBaseComponent extends DisplayDensityBase implements
418418
}
419419

420420
/**
421-
* Sets the cross-field filtering state of the `IgxGridComponent`.
421+
* Sets the advanced filtering state of the `IgxGridComponent`.
422422
* ```typescript
423-
* const logic = new FilteringExpressionsTree(FilteringLogic.And, "ID");
423+
* const logic = new FilteringExpressionsTree(FilteringLogic.And);
424424
* logic.filteringOperands = [
425425
* {
426426
* condition: IgxNumberFilteringOperand.instance().condition('greaterThan'),
427427
* fieldName: 'ID',
428428
* searchVal: 1
429+
* },
430+
* {
431+
* condition: IgxStringFilteringOperand.instance().condition('contains'),
432+
* fieldName: 'CompanyName',
433+
* searchVal: 'a'
429434
* }
430435
* ];
431436
* this.grid.advancedFilteringExpressionsTree = logic;

0 commit comments

Comments
 (0)