Merge pull request #8290 from IgniteUI/bpenkov/time-picker-onvaluechanged

Emit onValueChanged if 00:00 is cleared

Author: Lipata

projects/igniteui-angular/src/lib/time-picker/time-picker.component.spec.ts

@@ -1416,6 +1416,15 @@ describe('IgxTimePicker', () => {
             expect(timePicker.onValidationFailed.emit).toHaveBeenCalled();
         }));
 
+        it('should trigger onValueChanged if 00:00 is cleared from the input', () => {
+            fixture.componentInstance.date = new Date(2018, 10, 27, 0, 0, 0, 0);
+            fixture.detectChanges();
+            spyOn(timePicker.onValueChanged, 'emit');
+            timePicker.clear();
+            fixture.detectChanges();
+            expect(timePicker.onValueChanged.emit).toHaveBeenCalledTimes(1);
+        });
+
         it('should scroll on dropdown opened and accept value when focus lost', fakeAsync(() => {
             fixture.detectChanges();
 

projects/igniteui-angular/src/lib/time-picker/time-picker.component.ts

@@ -1958,7 +1958,7 @@ export class IgxTimePickerComponent implements
             // TODO: refactoring - this.value should be null #6585
             this.value?.setHours(0, 0, 0);
 
-            if (oldVal.getTime() !== this.value.getTime()) {
+            if (oldVal.getTime() !== this.value?.getTime() || this.isReset()) {
                 const args: IgxTimePickerValueChangedEventArgs = {
                     oldValue: oldVal,
                     newValue: this.value
@@ -2001,7 +2001,7 @@ export class IgxTimePickerComponent implements
             // TODO: refactoring - this.value should be null #6585
             this.value?.setHours(0, 0, 0);
             this.displayValue = inputMask;
-            if (oldVal.getTime() !== this.value?.getTime()) {
+            if (oldVal.getTime() !== this.value?.getTime() || this.isReset()) {
                 // TODO: Do not emit event when the editor is empty #6482
                 const args: IgxTimePickerValueChangedEventArgs = {
                     oldValue: oldVal,
@@ -2154,6 +2154,14 @@ export class IgxTimePickerComponent implements
             input.valid = IgxInputState.INITIAL;
         }
     }
+
+    // Workaround method for #8135
+    // TODO: It must be removed in #6482
+    private isReset(): boolean {
+        return this.value?.getHours() === 0
+            && this.value?.getMinutes() === 0
+            && this.value?.getSeconds() === 0;
+    }
 }
 
 /**