Skip to content

Commit b61348e

Browse files
Teodosia HristodorovaTeodosia Hristodorova
Teodosia Hristodorova
authored and
Teodosia Hristodorova
committed
chore(*): clean up leftover changes
1 parent dedc8d8 commit b61348e

File tree

5 files changed

+8
-14
lines changed

5 files changed

+8
-14
lines changed

projects/igniteui-angular/src/lib/grids/grid/grid.component.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import { IgxGridSummaryService } from '../summaries/grid-summary.service';
2525
import { IgxGridSelectionService, IgxGridCRUDService } from '../selection/selection.service';
2626
import { IgxForOfSyncService, IgxForOfScrollSyncService } from '../../directives/for-of/for_of.sync.service';
2727
import { IgxGridMRLNavigationService } from '../grid-mrl-navigation.service';
28-
import { FilterMode, GridSelectionMode } from '../common/enums';
28+
import { FilterMode } from '../common/enums';
2929
import { GridType } from '../common/grid.interface';
3030
import { IgxGroupByRowSelectorDirective } from '../selection/row-selectors';
3131

projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-grid.component.ts

-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ import { IgxForOfSyncService, IgxForOfScrollSyncService } from '../../directives
3636
import { GridType } from '../common/grid.interface';
3737
import { IgxRowIslandAPIService } from './row-island-api.service';
3838
import { IgxGridToolbarDirective, IgxGridToolbarTemplateContext } from '../toolbar/common';
39-
import { GridSelectionMode } from '../common/enums';
4039

4140
let NEXT_ID = 0;
4241

projects/igniteui-angular/src/lib/grids/selection/selection.service.ts

-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import { FilteringExpressionsTree } from '../../data-operations/filtering-expres
44
import { IGridEditEventArgs, IGridEditDoneEventArgs } from '../common/events';
55
import { GridType } from '../common/grid.interface';
66
import { IgxGridBaseDirective } from '../grid/public_api';
7-
import { IgxTreeGridAPIService } from '../tree-grid/public_api';
87

98
export interface GridSelectionRange {
109
rowStart: number;

projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid-selection.service.ts

+5-7
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ export class IgxTreeGridSelectionService extends IgxGridSelectionService {
1010
private rowsToBeIndeterminate: Set<any>;
1111

1212
/** Select specified rows. No event is emitted. */
13-
selectRowsWithNoEvent(rowIDs: any[], clearPrevSelection?): void {
13+
public selectRowsWithNoEvent(rowIDs: any[], clearPrevSelection?): void {
1414
if (this.grid && this.grid.rowSelection === GridSelectionMode.multipleCascade) {
1515
this.cascadeSelectRowsWithNoEvent(rowIDs, clearPrevSelection);
1616
return;
@@ -19,7 +19,7 @@ export class IgxTreeGridSelectionService extends IgxGridSelectionService {
1919
}
2020

2121
/** Deselect specified rows. No event is emitted. */
22-
deselectRowsWithNoEvent(rowIDs: any[]): void {
22+
public deselectRowsWithNoEvent(rowIDs: any[]): void {
2323
if (this.grid.rowSelection === GridSelectionMode.multipleCascade) {
2424
this.cascadeDeselectRowsWithNoEvent(rowIDs);
2525
return;
@@ -56,7 +56,7 @@ export class IgxTreeGridSelectionService extends IgxGridSelectionService {
5656
if (!parents.size) {
5757
this.rowSelection = new Set(this.rowsToBeSelected);
5858
this.indeterminateRows = new Set(this.rowsToBeIndeterminate);
59-
// TO DO: emit selectionChangeD event, calculate its args through the handleAddedAndRemovedArgs method
59+
// TODO: emit selectionChangeD event, calculate its args through the handleAddedAndRemovedArgs method
6060
this.clearHeaderCBState();
6161
this.selectedRowsChange.next();
6262
return;
@@ -71,7 +71,7 @@ export class IgxTreeGridSelectionService extends IgxGridSelectionService {
7171
this.updateCascadeSelectionOnFilterAndCRUD(newParents, null, visibleRowIDs);
7272
}
7373

74-
cascadeSelectRowsWithNoEvent(rowIDs: any[], clearPrevSelection?: boolean): void {
74+
private cascadeSelectRowsWithNoEvent(rowIDs: any[], clearPrevSelection?: boolean): void {
7575
if (clearPrevSelection) {
7676
this.indeterminateRows.clear();
7777
this.rowSelection.clear();
@@ -92,7 +92,7 @@ export class IgxTreeGridSelectionService extends IgxGridSelectionService {
9292
this.selectedRowsChange.next();
9393
}
9494

95-
cascadeDeselectRowsWithNoEvent(rowIDs: any[]): void {
95+
private cascadeDeselectRowsWithNoEvent(rowIDs: any[]): void {
9696
const args = { added: [], removed: rowIDs };
9797
this.calculateRowsNewSelectionState(args);
9898

@@ -143,8 +143,6 @@ export class IgxTreeGridSelectionService extends IgxGridSelectionService {
143143
}
144144

145145

146-
147-
148146
/**
149147
* retrieve the rows which should be added/removed to/from the old selection
150148
*/

projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid-selection.spec.ts

+2-4
Original file line numberDiff line numberDiff line change
@@ -285,23 +285,21 @@ describe('IgxTreeGrid - Selection #tGrid', () => {
285285
TreeGridFunctions.verifyTreeRowSelectionByIndex(fix, 1, false);
286286
}));
287287

288-
it('Should bind selectedRows properly', fakeAsync(() => {
288+
it('Should bind selectedRows properly', () => {
289289
fix.componentInstance.selectedRows = [147, 19, 957];
290290
fix.detectChanges();
291-
tick(100);
292291

293292
expect(treeGrid.getRowByIndex(0).selected).toBeTrue();
294293
expect(treeGrid.getRowByIndex(7).selected).toBeTrue();
295294
expect(treeGrid.getRowByIndex(4).selected).toBeFalse();
296295

297296
fix.componentInstance.selectedRows = [847, 711];
298297
fix.detectChanges();
299-
tick(100);
300298

301299
expect(treeGrid.getRowByIndex(0).selected).toBeFalse();
302300
expect(treeGrid.getRowByIndex(4).selected).toBeTrue();
303301
expect(treeGrid.getRowByIndex(8).selected).toBeTrue();
304-
}));
302+
});
305303
});
306304

307305
describe('UI Row Selection', () => {

0 commit comments

Comments
 (0)