Skip to content

Commit bbea09f

Browse files
SisIvanovadesig9steinkdinevsimeonoff
authored
fix(themes): icon sizing discrepancies (#13245)
* fix(themes): icon sizing discrepancies Closes #13238 --------- Co-authored-by: Marin Popov <[email protected]> Co-authored-by: Konstantin Dinev <[email protected]> Co-authored-by: Simeon Simeonoff <[email protected]>
1 parent a170147 commit bbea09f

File tree

4 files changed

+47
-7
lines changed

4 files changed

+47
-7
lines changed

projects/igniteui-angular/src/lib/core/styles/components/button/_button-theme.scss

+9
Original file line numberDiff line numberDiff line change
@@ -556,6 +556,7 @@
556556
}
557557

558558
igx-icon {
559+
--component-size: var(--ig-size, var(--ig-size-large));
559560
display: flex;
560561
justify-content: center;
561562
width: var(--igx-icon-size, #{$icon-in-button-size});
@@ -570,10 +571,18 @@
570571

571572
%igx-button-display--cosy {
572573
--component-size: var(--ig-size, var(--ig-size-medium));
574+
575+
igx-icon {
576+
--component-size: var(--ig-size, var(--ig-size-medium));
577+
}
573578
}
574579

575580
%igx-button-display--compact {
576581
--component-size: var(--ig-size, var(--ig-size-small));
582+
583+
igx-icon {
584+
--component-size: var(--ig-size, var(--ig-size-small));
585+
}
577586
}
578587

579588
igx-grid-filtering-row {

projects/igniteui-angular/src/lib/core/styles/components/chip/_chip-theme.scss

+12-6
Original file line numberDiff line numberDiff line change
@@ -398,9 +398,13 @@
398398
}
399399

400400
igx-avatar,
401-
igx-circular-bar {
402-
--component-size: 3;
401+
igx-circular-bar,
402+
igx-icon {
403+
--component-size: var(--ig-size, var(--ig-size-large));
404+
}
403405

406+
igx-avatar,
407+
igx-circular-bar {
404408
$avatar-size: (
405409
comfortable: rem(24px),
406410
cosy: rem(18),
@@ -426,14 +430,16 @@
426430
}
427431

428432
%igx-chip__item--cosy {
429-
igx-avatar {
430-
--component-size: 2;
433+
igx-avatar,
434+
igx-icon {
435+
--component-size: var(--ig-size, var(--ig-size-medium));
431436
}
432437
}
433438

434439
%igx-chip__item--compact {
435-
igx-avatar {
436-
--component-size: 1;
440+
igx-avatar,
441+
igx-icon {
442+
--component-size: var(--ig-size, var(--ig-size-small));
437443
}
438444
}
439445

projects/igniteui-angular/src/lib/core/styles/components/grid/_grid-theme.scss

+21
Original file line numberDiff line numberDiff line change
@@ -864,6 +864,15 @@
864864
display: flex;
865865
overflow: hidden;
866866

867+
%igx-grid__header-indentation {
868+
igx-icon {
869+
--component-size: var(--ig-size, var(--ig-size-large));
870+
font-size: rem(24px);
871+
width: rem(24px);
872+
height: rem(24px);
873+
}
874+
}
875+
867876
%igx-grid__drag-indicator {
868877
cursor: default;
869878
}
@@ -879,12 +888,24 @@
879888
}
880889

881890
%grid-thead--cosy {
891+
%igx-grid__header-indentation {
892+
igx-icon {
893+
--component-size: var(--ig-size, var(--ig-size-medium));
894+
}
895+
}
896+
882897
%grid__cbx-selection--push--cosy {
883898
align-items: flex-start;
884899
}
885900
}
886901

887902
%grid-thead--compact {
903+
%igx-grid__header-indentation {
904+
igx-icon {
905+
--component-size: var(--ig-size, var(--ig-size-small));
906+
}
907+
}
908+
888909
%grid__cbx-selection--push--compact {
889910
align-items: flex-start;
890911
}

projects/igniteui-angular/src/lib/core/styles/components/grid/_pivot-data-selector-theme.scss

+5-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,10 @@
8787
%form-group-prefix,
8888
%form-group-prefix--cosy,
8989
%form-group-prefix--compact {
90-
padding-inline-end: rem(16px) !important;
90+
@if $variant == 'material' {
91+
padding-inline-end: rem(16px) !important;
92+
}
93+
9194
box-sizing: content-box;
9295
}
9396

@@ -125,6 +128,7 @@
125128

126129
> h6 {
127130
font-size: rem(12px);
131+
margin-bottom: 0;
128132
}
129133
}
130134

0 commit comments

Comments
 (0)