Skip to content

Commit bf75f47

Browse files
committed
refactor(IgxColumn): address the requested changes #3343
1 parent 6a418ec commit bf75f47

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

projects/igniteui-angular/src/lib/grids/columns/column-group.component.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export class IgxColumnGroupComponent extends IgxColumnComponent implements After
4040
this._collapsible = value;
4141
this.collapsibleChange.emit(this._collapsible);
4242
if (this.children && !this.hidden) {
43-
if (value) {
43+
if (this._collapsible) {
4444
this.setExpandCollapseState();
4545
} else {
4646
this.children.forEach(child => child.hidden = false);
@@ -203,8 +203,8 @@ export class IgxColumnGroupComponent extends IgxColumnComponent implements After
203203
set hidden(value: boolean) {
204204
this._hidden = value;
205205
this.hiddenChange.emit(this._hidden);
206-
if (value || !this.collapsible) {
207-
this.children.forEach(child => child.hidden = value);
206+
if (this._hidden || !this.collapsible) {
207+
this.children.forEach(child => child.hidden = this._hidden);
208208
} else {
209209
this.children.forEach(c => {
210210
if (c.visibleWhenCollapsed === undefined) {c.hidden = false; return; }

projects/igniteui-angular/src/lib/grids/columns/column.component.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1051,15 +1051,12 @@ export class IgxColumnComponent implements AfterContentInit {
10511051
* ```
10521052
* @memberof IgxColumnComponent
10531053
*/
1054+
@notifyChanges(true)
10541055
@Input()
10551056
set visibleWhenCollapsed(value: boolean) {
10561057
this._visibleWhenCollapsed = value;
10571058
this.visibleWhenCollapsedChange.emit(this._visibleWhenCollapsed);
10581059
if (this.parent) { this.parent.setExpandCollapseState(); }
1059-
if (this.grid) {
1060-
this.grid.notifyChanges(true);
1061-
}
1062-
10631060
}
10641061

10651062
get visibleWhenCollapsed(): boolean {

0 commit comments

Comments
 (0)