Skip to content

Commit c09b05f

Browse files
damyanpetevdamyanpetev
committed
test(banner): fix fixture elements contexts #4908 
1 parent be3b98c commit c09b05f

File tree

1 file changed

+77
-77
lines changed

1 file changed

+77
-77
lines changed

‎projects/igniteui-angular/src/lib/banner/banner.component.spec.ts

+77-77
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,12 @@ const CSS_CLASS_BANNER_ACTIONS = 'igx-banner__actions';
2121
const CSS_CLASS_BANNER_ROW = 'igx-banner__row';
2222

2323
describe('igxBanner', () => {
24-
const bannerElement: DebugElement = null;
25-
const bannerMessageElement: DebugElement = null;
26-
const bannerIllustrationElement: DebugElement = null;
27-
const bannerTextElement: DebugElement = null;
28-
const bannerActionsElement: DebugElement = null;
29-
const bannerRowElement: DebugElement = null;
24+
let bannerElement: DebugElement = null;
25+
let bannerMessageElement: DebugElement = null;
26+
let bannerIllustrationElement: DebugElement = null;
27+
let bannerTextElement: DebugElement = null;
28+
let bannerActionsElement: DebugElement = null;
29+
let bannerRowElement: DebugElement = null;
3030

3131
configureTestSuite();
3232
beforeEach(async(() => {
@@ -112,12 +112,12 @@ describe('igxBanner', () => {
112112

113113
getBaseClassElements(fixture);
114114

115-
expect(this.bannerElement).toBeNull();
116-
expect(this.bannerMessageElement).toBeNull();
117-
expect(this.bannerIllustrationElement).toBeNull();
118-
expect(this.bannerTextElement).toBeNull();
119-
expect(this.bannerActionsElement).toBeNull();
120-
expect(this.bannerRowElement).toBeNull();
115+
expect(bannerElement).toBeNull();
116+
expect(bannerMessageElement).toBeNull();
117+
expect(bannerIllustrationElement).toBeNull();
118+
expect(bannerTextElement).toBeNull();
119+
expect(bannerActionsElement).toBeNull();
120+
expect(bannerRowElement).toBeNull();
121121

122122
const banner = fixture.componentInstance.banner;
123123
banner.open();
@@ -126,12 +126,12 @@ describe('igxBanner', () => {
126126

127127
getBaseClassElements(fixture);
128128

129-
expect(this.bannerElement).toBeDefined();
130-
expect(this.bannerMessageElement).toBeDefined();
131-
expect(this.bannerIllustrationElement).toBeDefined();
132-
expect(this.bannerTextElement).toBeDefined();
133-
expect(this.bannerActionsElement).toBeDefined();
134-
expect(this.bannerRowElement).toBeDefined();
129+
expect(bannerElement).toBeDefined();
130+
expect(bannerMessageElement).toBeDefined();
131+
expect(bannerIllustrationElement).toBeDefined();
132+
expect(bannerTextElement).toBeDefined();
133+
expect(bannerActionsElement).toBeDefined();
134+
expect(bannerRowElement).toBeDefined();
135135
}));
136136

137137
it('Should initialize banner with at least one and up to two buttons', fakeAsync(() => {
@@ -140,12 +140,12 @@ describe('igxBanner', () => {
140140

141141
getBaseClassElements(fixture);
142142

143-
expect(this.bannerElement).toBeNull();
144-
expect(this.bannerMessageElement).toBeNull();
145-
expect(this.bannerIllustrationElement).toBeNull();
146-
expect(this.bannerTextElement).toBeNull();
147-
expect(this.bannerActionsElement).toBeNull();
148-
expect(this.bannerRowElement).toBeNull();
143+
expect(bannerElement).toBeNull();
144+
expect(bannerMessageElement).toBeNull();
145+
expect(bannerIllustrationElement).toBeNull();
146+
expect(bannerTextElement).toBeNull();
147+
expect(bannerActionsElement).toBeNull();
148+
expect(bannerRowElement).toBeNull();
149149

150150
const banner = fixture.componentInstance.banner;
151151
banner.open();
@@ -154,25 +154,25 @@ describe('igxBanner', () => {
154154

155155
getBaseClassElements(fixture);
156156

157-
expect(this.bannerElement).not.toBeNull();
158-
expect(this.bannerMessageElement).not.toBeNull();
159-
expect(this.bannerIllustrationElement).not.toBeNull();
160-
expect(this.bannerTextElement).not.toBeNull();
161-
expect(this.bannerActionsElement).not.toBeNull();
162-
expect(this.bannerRowElement).not.toBeNull();
157+
expect(bannerElement).not.toBeNull();
158+
expect(bannerMessageElement).not.toBeNull();
159+
expect(bannerIllustrationElement).not.toBeNull();
160+
expect(bannerTextElement).not.toBeNull();
161+
expect(bannerActionsElement).not.toBeNull();
162+
expect(bannerRowElement).not.toBeNull();
163163

164164
banner.close();
165165
tick();
166166
fixture.detectChanges();
167167

168168
getBaseClassElements(fixture);
169169

170-
expect(this.bannerElement).toBeNull();
171-
expect(this.bannerMessageElement).toBeNull();
172-
expect(this.bannerIllustrationElement).toBeNull();
173-
expect(this.bannerTextElement).toBeNull();
174-
expect(this.bannerActionsElement).toBeNull();
175-
expect(this.bannerRowElement).toBeNull();
170+
expect(bannerElement).toBeNull();
171+
expect(bannerMessageElement).toBeNull();
172+
expect(bannerIllustrationElement).toBeNull();
173+
expect(bannerTextElement).toBeNull();
174+
expect(bannerActionsElement).toBeNull();
175+
expect(bannerRowElement).toBeNull();
176176
}));
177177

178178
it('Should position buttons next to the banner content', fakeAsync(() => {
@@ -186,8 +186,8 @@ describe('igxBanner', () => {
186186

187187
getBaseClassElements(fixture);
188188

189-
const bannerMessageElementTop = this.bannerMessageElement.nativeElement.getClientRects().y;
190-
const bannerActionsElementTop = this.bannerActionsElement.nativeElement.getClientRects().y;
189+
const bannerMessageElementTop = bannerMessageElement.nativeElement.getClientRects().y;
190+
const bannerActionsElementTop = bannerActionsElement.nativeElement.getClientRects().y;
191191

192192
expect(bannerMessageElementTop).toBe(bannerActionsElementTop);
193193
}));
@@ -268,14 +268,14 @@ describe('igxBanner', () => {
268268

269269
getBaseClassElements(fixture);
270270

271-
expect(this.bannerMessageElement).not.toBeNull();
272-
expect(this.bannerIllustrationElement).not.toBeNull();
273-
expect(this.bannerTextElement).not.toBeNull();
274-
expect(this.bannerTextElement.nativeElement.innerHTML.trim()).
271+
expect(bannerMessageElement).not.toBeNull();
272+
expect(bannerIllustrationElement).not.toBeNull();
273+
expect(bannerTextElement).not.toBeNull();
274+
expect(bannerTextElement.nativeElement.innerHTML.trim()).
275275
toEqual('Unfortunately, the credit card did not go through, please try again.');
276-
expect(this.bannerActionsElement).not.toBeNull();
276+
expect(bannerActionsElement).not.toBeNull();
277277

278-
const buttons = this.bannerActionsElement.nativeElement.querySelectorAll('button');
278+
const buttons = bannerActionsElement.nativeElement.querySelectorAll('button');
279279
expect(buttons.length).toEqual(2);
280280
buttons[0].click();
281281
tick();
@@ -287,8 +287,8 @@ describe('igxBanner', () => {
287287
expect(banner.onClosed.emit).toHaveBeenCalledTimes(1);
288288
expect(banner.onExpansionPanelClose).toHaveBeenCalledTimes(1);
289289
expect(banner.collapsed).toBeTruthy();
290-
expect(this.bannerMessageElement).toBeNull();
291-
expect(this.bannerActionsElement).toBeNull();
290+
expect(bannerMessageElement).toBeNull();
291+
expect(bannerActionsElement).toBeNull();
292292

293293
banner.open();
294294
tick();
@@ -300,12 +300,12 @@ describe('igxBanner', () => {
300300
expect(banner.onOpened.emit).toHaveBeenCalledTimes(2);
301301
expect(banner.onExpansionPanelOpen).toHaveBeenCalledTimes(2);
302302
expect(banner.collapsed).toBeFalsy();
303-
expect(this.bannerMessageElement).not.toBeNull();
304-
expect(this.bannerIllustrationElement).not.toBeNull();
305-
expect(this.bannerTextElement).not.toBeNull();
306-
expect(this.bannerTextElement.nativeElement.innerHTML.trim()).
303+
expect(bannerMessageElement).not.toBeNull();
304+
expect(bannerIllustrationElement).not.toBeNull();
305+
expect(bannerTextElement).not.toBeNull();
306+
expect(bannerTextElement.nativeElement.innerHTML.trim()).
307307
toEqual('Unfortunately, the credit card did not go through, please try again.');
308-
expect(this.bannerActionsElement).not.toBeNull();
308+
expect(bannerActionsElement).not.toBeNull();
309309

310310
buttons[1].click();
311311
tick();
@@ -316,8 +316,8 @@ describe('igxBanner', () => {
316316
expect(banner.onClosed.emit).toHaveBeenCalledTimes(2);
317317
expect(banner.onExpansionPanelClose).toHaveBeenCalledTimes(2);
318318
expect(banner.collapsed).toBeTruthy();
319-
expect(this.bannerMessageElement).toBeNull();
320-
expect(this.bannerActionsElement).toBeNull();
319+
expect(bannerMessageElement).toBeNull();
320+
expect(bannerActionsElement).toBeNull();
321321
}));
322322

323323
it('Should not be dismissed on user actions outside the component', () => {
@@ -425,32 +425,32 @@ describe('igxBanner', () => {
425425
expect(bannerNode.childElementCount).toEqual(1); // collapsed expansion panel
426426
expect(bannerNode.firstElementChild.childElementCount).toEqual(0); // no content
427427
getBaseClassElements(fixture);
428-
expect(this.bannerElement).toBeNull();
429-
expect(this.bannerMessageElement).toBeNull();
430-
expect(this.bannerIllustrationElement).toBeNull();
431-
expect(this.bannerTextElement).toBeNull();
432-
expect(this.bannerActionsElement).toBeNull();
433-
expect(this.bannerRowElement).toBeNull();
428+
expect(bannerElement).toBeNull();
429+
expect(bannerMessageElement).toBeNull();
430+
expect(bannerIllustrationElement).toBeNull();
431+
expect(bannerTextElement).toBeNull();
432+
expect(bannerActionsElement).toBeNull();
433+
expect(bannerRowElement).toBeNull();
434434
banner.toggle();
435435
tick();
436436
fixture.detectChanges();
437437
getBaseClassElements(fixture);
438-
expect(this.bannerElement).not.toBeNull();
439-
expect(this.bannerMessageElement).not.toBeNull();
440-
expect(this.bannerIllustrationElement).not.toBeNull();
441-
expect(this.bannerTextElement).not.toBeNull();
442-
expect(this.bannerActionsElement).not.toBeNull();
443-
expect(this.bannerRowElement).not.toBeNull();
438+
expect(bannerElement).not.toBeNull();
439+
expect(bannerMessageElement).not.toBeNull();
440+
expect(bannerIllustrationElement).not.toBeNull();
441+
expect(bannerTextElement).not.toBeNull();
442+
expect(bannerActionsElement).not.toBeNull();
443+
expect(bannerRowElement).not.toBeNull();
444444
banner.toggle();
445445
tick();
446446
fixture.detectChanges();
447447
getBaseClassElements(fixture);
448-
expect(this.bannerElement).toBeNull();
449-
expect(this.bannerMessageElement).toBeNull();
450-
expect(this.bannerIllustrationElement).toBeNull();
451-
expect(this.bannerTextElement).toBeNull();
452-
expect(this.bannerActionsElement).toBeNull();
453-
expect(this.bannerRowElement).toBeNull();
448+
expect(bannerElement).toBeNull();
449+
expect(bannerMessageElement).toBeNull();
450+
expect(bannerIllustrationElement).toBeNull();
451+
expect(bannerTextElement).toBeNull();
452+
expect(bannerActionsElement).toBeNull();
453+
expect(bannerRowElement).toBeNull();
454454
}));
455455

456456
it('Should apply all appropriate classes on initialization_custom template', fakeAsync(() => {
@@ -499,12 +499,12 @@ describe('igxBanner', () => {
499499
});
500500

501501
const getBaseClassElements = <T>(fixture: ComponentFixture<T>) => {
502-
this.bannerElement = fixture.debugElement.query(By.css('.' + CSS_CLASS_BANNER));
503-
this.bannerMessageElement = fixture.debugElement.query(By.css('.' + CSS_CLASS_BANNER_MESSAGE));
504-
this.bannerIllustrationElement = fixture.debugElement.query(By.css('.' + CSS_CLASS_BANNER_ILLUSTRATION));
505-
this.bannerTextElement = fixture.debugElement.query(By.css('.' + CSS_CLASS_BANNER_TEXT));
506-
this.bannerActionsElement = fixture.debugElement.query(By.css('.' + CSS_CLASS_BANNER_ACTIONS));
507-
this.bannerRowElement = fixture.debugElement.query(By.css('.' + CSS_CLASS_BANNER_ROW));
502+
bannerElement = fixture.debugElement.query(By.css('.' + CSS_CLASS_BANNER));
503+
bannerMessageElement = fixture.debugElement.query(By.css('.' + CSS_CLASS_BANNER_MESSAGE));
504+
bannerIllustrationElement = fixture.debugElement.query(By.css('.' + CSS_CLASS_BANNER_ILLUSTRATION));
505+
bannerTextElement = fixture.debugElement.query(By.css('.' + CSS_CLASS_BANNER_TEXT));
506+
bannerActionsElement = fixture.debugElement.query(By.css('.' + CSS_CLASS_BANNER_ACTIONS));
507+
bannerRowElement = fixture.debugElement.query(By.css('.' + CSS_CLASS_BANNER_ROW));
508508
};
509509
});
510510

0 commit comments

Comments
 (0)