chore(select): Address comments -1 #5911

Author: IvayloG

projects/igniteui-angular/src/lib/combo/combo-dropdown.component.ts

@@ -29,7 +29,8 @@ export class IgxComboDropDownComponent extends IgxDropDownComponent implements I
         super(elementRef, cdr, selection, _displayDensityOptions);
     }
 
-    protected get scrollContainer() {
+    /** @hidden @internal */
+   public get scrollContainer() {
         return this.virtDir.dc.location.nativeElement;
     }
 

projects/igniteui-angular/src/lib/drop-down/drop-down.base.ts

@@ -27,9 +27,10 @@ export class IgxDropDownBaseDirective extends DisplayDensityBase implements IDro
     protected _id = `igx-drop-down-${NEXT_ID++}`;
 
     /**
+     * @hidden @internal
      * Get dropdown's html element of its scroll container
      */
-    protected get scrollContainer() {
+    public get scrollContainer() {
         return this.element;
     }
 

projects/igniteui-angular/src/lib/drop-down/drop-down.component.ts

@@ -205,7 +205,8 @@ export class IgxDropDownComponent extends IgxDropDownBaseDirective implements ID
         return this.toggleDirective.collapsed;
     }
 
-    protected get scrollContainer() {
+    /** @hidden @internal */
+    public get scrollContainer() {
         return this.scrollContainerRef.nativeElement;
     }
 

projects/igniteui-angular/src/lib/select/select-positioning-strategy.ts

@@ -170,7 +170,7 @@ export class SelectPositioningStrategy extends BaseFitPositionStrategy implement
         selectFit.styles = {};
         selectFit.itemElement = this.getInteractionItemElement();
         selectFit.itemHeight = itemHeight;
-        selectFit.dropDownList = this.select.getListItemsContainer();
+        selectFit.dropDownList = this.select.scrollContainer;
         selectFit.targetRect = targetRect;
         selectFit.contentElementRect = contentElementRect;
         selectFit.inputElement = this.select.getEditElement();
@@ -209,7 +209,7 @@ export class SelectPositioningStrategy extends BaseFitPositionStrategy implement
             itemElement = this.select.selectedItem.element.nativeElement;
             // D.P. Feb 22 2019, #3921 Force item scroll before measuring in IE11, due to base scrollToItem delay
             if (isIE()) {
-                this.select.getListItemsContainer().scrollTop = this.select.calculateScrollPosition(this.select.selectedItem);
+                this.select.scrollContainer.scrollTop = this.select.calculateScrollPosition(this.select.selectedItem);
             }
         } else {
             itemElement = this.select.getFirstItemElement();

projects/igniteui-angular/src/lib/select/select.component.html

@@ -34,8 +34,7 @@
         <ng-content *ngTemplateOutlet="headerTemplate"></ng-content>
     </div>
 
-    <div #scrollContainer class="igx-drop-down__list--select" style="overflow-y: auto;"
-        [style.maxHeight]="maxHeight" [attr.id]="this.listId" role="listbox">
+    <div #scrollContainer class="igx-drop-down__list--select" [style.maxHeight]="maxHeight" [attr.id]="this.listId" role="listbox">
         <ng-content select="igx-select-item, igx-select-item-group">
         </ng-content>
     </div>

projects/igniteui-angular/src/lib/services/overlay/position/base-fit-position-strategy.ts

@@ -9,9 +9,9 @@ export abstract class BaseFitPositionStrategy extends ConnectedPositioningStrate
     position(contentElement: HTMLElement, size: Size, document?: Document, initialCall?: boolean): void {
         const targetRect = Util.getTargetRect(this.settings);
         const contentElementRect = contentElement.getBoundingClientRect();
-        let exposedConnectedFit = {};
+        // let exposedConnectedFit = {};
+        const connectedFit: ConnectedFit = {};
         if (initialCall) {
-            const connectedFit: ConnectedFit = {};
             connectedFit.targetRect = targetRect;
             connectedFit.contentElementRect = contentElementRect;
             this._initialSettings = this._initialSettings || Object.assign({}, this.settings);
@@ -21,9 +21,10 @@ export abstract class BaseFitPositionStrategy extends ConnectedPositioningStrate
             if (!connectedFit.fitHorizontal || !connectedFit.fitVertical) {
                 this.fitInViewport(contentElement, connectedFit);
             }
-            exposedConnectedFit = connectedFit;
+            //exposedConnectedFit = connectedFit;
         }
-        this.setStyle(contentElement, targetRect, contentElementRect, exposedConnectedFit);
+        // this.setStyle(contentElement, targetRect, contentElementRect, exposedConnectedFit);
+        this.setStyle(contentElement, targetRect, contentElementRect, connectedFit);
     }
 
     /**