Skip to content

Commit c9c9244

Browse files
authored
Merge pull request #9067 from IgniteUI/dTsvetkov/fix-lint-warnings-summary-sorting
fix(lint): Summary and sorting lint warnings
2 parents ab8304f + ea0fc79 commit c9c9244

File tree

5 files changed

+13
-12
lines changed

5 files changed

+13
-12
lines changed

projects/igniteui-angular/src/lib/data-operations/sorting-strategy.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ export class NoopSortingStrategy implements IGridSortingStrategy {
8888
return this._instance || (this._instance = new NoopSortingStrategy());
8989
}
9090

91-
public sort(data: any[], expressions: ISortingExpression[]): any[] {
91+
public sort(data: any[]): any[] {
9292
return data;
9393
}
9494
}

projects/igniteui-angular/src/lib/grids/summaries/grid-root-summary.pipe.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ export class IgxSummaryDataPipe implements PipeTransform {
1111

1212
constructor(private gridAPI: GridBaseAPIService<IgxGridBaseDirective & GridType>) { }
1313

14-
transform(id: string, trigger: number = 0) {
14+
// eslint-disable-next-line @typescript-eslint/no-unused-vars
15+
public transform(id: string, trigger: number = 0) {
1516
const summaryService = this.gridAPI.grid.summaryService;
1617
return summaryService.calculateSummaries(
1718
summaryService.rootSummaryID,

projects/igniteui-angular/src/lib/grids/summaries/grid-summary.service.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -211,8 +211,8 @@ export class IgxGridSummaryService {
211211
}
212212

213213
// TODO: remove only deleted rows
214-
private removeChildRowSummaries(rowID, columnName?) {
215-
}
214+
// private removeChildRowSummaries(rowID, columnName?) {
215+
// }
216216

217217
private compareGroupingExpressions(current, groupingArgs) {
218218
const newExpressions = groupingArgs.expressions.map(record => record.fieldName);

projects/igniteui-angular/src/lib/grids/summaries/summary-cell.component.ts

+5-5
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export class IgxSummaryCellComponent {
4040
}
4141

4242
@HostBinding('attr.data-visibleIndex')
43-
get visibleColumnIndex(): number {
43+
public get visibleColumnIndex(): number {
4444
return this.column.visibleIndex;
4545
}
4646

@@ -68,19 +68,19 @@ export class IgxSummaryCellComponent {
6868
};
6969
}
7070

71-
get width() {
71+
public get width() {
7272
return this.column.getCellWidth();
7373
}
7474

75-
get nativeElement(): any {
75+
public get nativeElement(): any {
7676
return this.element.nativeElement;
7777
}
7878

79-
get columnDatatype(): DataType {
79+
public get columnDatatype(): DataType {
8080
return this.column.dataType;
8181
}
8282

83-
get itemHeight() {
83+
public get itemHeight() {
8484
return this.column.grid.defaultSummaryHeight;
8585
}
8686

projects/igniteui-angular/src/lib/grids/summaries/summary-row.component.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,11 @@ export class IgxSummaryRowComponent implements DoCheck {
4242
public firstCellIndentation = -1;
4343

4444
@HostBinding('attr.data-rowIndex')
45-
get dataRowIndex() {
45+
public get dataRowIndex() {
4646
return this.index;
4747
}
4848

49-
get minHeight() {
49+
public get minHeight() {
5050
return this.grid.summaryService.calcMaxSummaryHeight() - 1;
5151
}
5252

@@ -117,7 +117,7 @@ export class IgxSummaryRowComponent implements DoCheck {
117117
return this.grid.unpinnedColumns;
118118
}
119119

120-
getContext(row) {
120+
public getContext(row) {
121121
return {
122122
$implicit: row
123123
};

0 commit comments

Comments
 (0)