test(igxGrid): Column spec failing test

Closes #488

Author: rkaraivanov

projects/igniteui-angular/src/lib/grid/column.component.ts

@@ -400,7 +400,7 @@ export class IgxColumnComponent implements AfterContentInit {
         if (this.columnGroup) {
             this.allChildren.forEach(child => child.pinned = true);
         }
-        // grid.reinitPinStates();
+        grid.reinitPinStates();
 
         grid.markForCheck();
         const newIndex = this.visibleIndex;

projects/igniteui-angular/src/lib/grid/column.spec.ts

@@ -121,23 +121,19 @@ describe('IgxGrid - Column properties', () => {
         const grid = fix.componentInstance.instance;
         let headers: DebugElement[];
 
-        expect(grid.columnList.first.index).toEqual(0);
         expect(grid.columnList.first.field).toMatch('ID');
-        expect(grid.columnList.last.index).toEqual(1);
         expect(grid.columnList.last.field).toMatch('Name');
 
         headers = fix.debugElement.queryAll(By.css(COLUMN_HEADER_CLASS));
         expect(headers[0].nativeElement.textContent).toMatch('ID');
         expect(headers[1].nativeElement.textContent).toMatch('Name');
 
-
+        // Swap columns
         grid.moveColumn(grid.columnList.first, grid.columnList.last);
         fix.detectChanges();
 
-        expect(grid.columnList.first.index).toEqual(1);
-        expect(grid.columnList.first.field).toMatch('ID');
-        expect(grid.columnList.last.index).toEqual(0);
-        expect(grid.columnList.last.field).toMatch('Name');
+        expect(grid.columnList.first.field).toMatch('Name');
+        expect(grid.columnList.last.field).toMatch('ID');
 
         headers = fix.debugElement.queryAll(By.css(COLUMN_HEADER_CLASS));
         expect(headers[0].nativeElement.textContent).toMatch('Name');

projects/igniteui-angular/src/lib/grid/grid.component.ts

@@ -1650,6 +1650,7 @@ export class IgxGridComponent implements OnInit, OnDestroy, AfterContentInit, Af
     protected initColumns(collection: QueryList<IgxColumnComponent>, cb: any = null) {
 
         // XXX: Deprecate index
+        this._columns = this.columnList.toArray();
 
         collection.forEach((column: IgxColumnComponent) => {
             column.gridID = this.id;
@@ -1660,9 +1661,6 @@ export class IgxGridComponent implements OnInit, OnDestroy, AfterContentInit, Af
                 cb(column);
             }
         });
-        this._columns = this.columnList.toArray();
-        // this._pinnedColumns = this.columnList.filter((c) => c.pinned);
-        // this._unpinnedColumns = this.columnList.filter((c) => !c.pinned);
         this.reinitPinStates();
     }
 

projects/igniteui-angular/src/lib/grid/grid.pinning.spec.ts

@@ -329,7 +329,6 @@ describe('IgxGrid - Column Pinning ', () => {
         tryPin = grid.pinColumn('ContactTitle');
         fix.detectChanges();
         expect(tryPin).toEqual(false);
-
         grid.unpinColumn('ContactName');
         fix.detectChanges();