refactor(grids): lint updates#10506

Author: tishko0

projects/igniteui-angular/src/lib/carousel/carousel.component.ts

@@ -317,7 +317,7 @@ export class IgxCarouselComponent extends IgxCarouselComponentBase implements On
      *
      * @memberOf IgxCarouselComponent
      */
-    @Output() public onSlideChanged = new EventEmitter<ISlideEventArgs>();
+    @Output() public slideChanged = new EventEmitter<ISlideEventArgs>();
 
     /**
      * An event that is emitted after a slide has been added to the carousel.
@@ -328,7 +328,7 @@ export class IgxCarouselComponent extends IgxCarouselComponentBase implements On
      *
      * @memberOf IgxCarouselComponent
      */
-    @Output() public onSlideAdded = new EventEmitter<ISlideEventArgs>();
+    @Output() public slideAdded = new EventEmitter<ISlideEventArgs>();
 
     /**
      * An event that is emitted after a slide has been removed from the carousel.
@@ -339,7 +339,7 @@ export class IgxCarouselComponent extends IgxCarouselComponentBase implements On
      *
      * @memberOf IgxCarouselComponent
      */
-    @Output() public onSlideRemoved = new EventEmitter<ISlideEventArgs>();
+    @Output() public slideRemoved = new EventEmitter<ISlideEventArgs>();
 
     /**
      * An event that is emitted after the carousel has been paused.
@@ -350,7 +350,7 @@ export class IgxCarouselComponent extends IgxCarouselComponentBase implements On
      *
      * @memberOf IgxCarouselComponent
      */
-    @Output() public onCarouselPaused = new EventEmitter<IgxCarouselComponent>();
+    @Output() public carouselPaused = new EventEmitter<IgxCarouselComponent>();
 
     /**
      * An event that is emitted after the carousel has resumed transitioning between `slides`.
@@ -361,7 +361,7 @@ export class IgxCarouselComponent extends IgxCarouselComponentBase implements On
      *
      * @memberOf IgxCarouselComponent
      */
-    @Output() public onCarouselPlaying = new EventEmitter<IgxCarouselComponent>();
+    @Output() public carouselPlaying = new EventEmitter<IgxCarouselComponent>();
 
     @ViewChild('defaultIndicator', { read: TemplateRef, static: true })
     private defaultIndicator: TemplateRef<any>;

projects/igniteui-angular/src/lib/core/displayDensity.ts

@@ -37,7 +37,7 @@ export const DisplayDensityToken = new InjectionToken<IDisplayDensityOptions>('D
 // eslint-disable-next-line @angular-eslint/directive-class-suffix
 export class DisplayDensityBase implements DoCheck, OnInit {
     @Output()
-    public onDensityChanged = new EventEmitter<IDensityChangedEventArgs>();
+    public densityChanged = new EventEmitter<IDensityChangedEventArgs>();
 
     /**
      * Returns the theme of the component.

projects/igniteui-angular/src/lib/core/selection.ts

@@ -180,7 +180,7 @@ export class IgxSelectionAPIService {
      * @param componentID ID of the component, which we add new items to.
      * @param itemIDs Array of IDs of the items to add to component selection.
      */
-    public deselect_items(componentID: string, itemID: any[], clearSelection?: boolean) {
+    public deselect_items(componentID: string, itemID: any[]) {
         this.set(componentID, this.delete_items(componentID, itemID));
     }
 

projects/igniteui-angular/src/lib/core/touch.ts

@@ -127,7 +127,7 @@ export class HammerGesturesManager {
      * @param element The DOM element used to create the manager on.
      */
     public getManagerForElement(element: EventTarget): HammerManager {
-        const result =  this._hammerManagers.filter((value, index, array) => value.element === element);
+        const result =  this._hammerManagers.filter((value) => value.element === element);
         return result.length ? result[0].manager : null;
     }
 

projects/igniteui-angular/src/lib/core/utils.spec.ts

@@ -1,4 +1,4 @@
-import { cloneValue, mergeObjects, isObject, isDate } from './utils';
+import { cloneValue, isObject, isDate } from './utils';
 import { SampleTestData } from '../test-utils/sample-test-data.spec';
 
 describe('Utils', () => {

projects/igniteui-angular/src/lib/data-operations/filtering-condition.spec.ts

@@ -155,7 +155,7 @@ class CustomFilter extends IgxFilteringOperand {
         super();
         this.append({
             name: 'Custom',
-            logic: (value: any, searchVal: any, ignoreCase: boolean) => value === searchVal,
+            logic: (value: any, searchVal: any) => value === searchVal,
             isUnary: false,
             iconName: 'starts-with'
         });

projects/igniteui-angular/src/lib/data-operations/filtering-condition.ts

@@ -77,7 +77,7 @@ export class IgxBooleanFilteringOperand extends IgxFilteringOperand {
             name: 'all',
             isUnary: true,
             iconName: 'select-all',
-            logic: (target: boolean) => true
+            logic: () => true
         }, {
             name: 'true',
             isUnary: true,

projects/igniteui-angular/src/lib/data-operations/filtering-expressions-tree.ts

@@ -38,7 +38,7 @@ export class FilteringExpressionsTree implements IFilteringExpressionsTree {
      *
      * @memberof FilteringExpressionsTree
      */
-    filteringOperands: (IFilteringExpressionsTree | IFilteringExpression)[] = [];
+    public filteringOperands: (IFilteringExpressionsTree | IFilteringExpression)[] = [];
 
     /**
      * Sets/gets the operator.
@@ -51,7 +51,7 @@ export class FilteringExpressionsTree implements IFilteringExpressionsTree {
      *
      * @memberof FilteringExpressionsTree
      */
-    operator: FilteringLogic;
+    public operator: FilteringLogic;
 
     /**
      * Sets/gets the field name of the column where the filtering expression is placed.
@@ -64,7 +64,7 @@ export class FilteringExpressionsTree implements IFilteringExpressionsTree {
      *
      * @memberof FilteringExpressionsTree
      */
-    fieldName?: string;
+    public fieldName?: string;
 
     /**
      * Sets/gets the type of the filtering expressions tree.
@@ -77,7 +77,7 @@ export class FilteringExpressionsTree implements IFilteringExpressionsTree {
      *
      * @memberof FilteringExpressionsTree
      */
-    type?: FilteringExpressionsTreeType;
+    public type?: FilteringExpressionsTreeType;
 
     constructor(operator: FilteringLogic, fieldName?: string) {
         this.operator = operator;

projects/igniteui-angular/src/lib/directives/button/button.directive.spec.ts

@@ -158,7 +158,7 @@ describe('IgxButton', () => {
 })
 class InitButtonComponent {
     @ViewChild(IgxButtonDirective, { read: IgxButtonDirective, static: true })
-    button: IgxButtonDirective;
+    public button: IgxButtonDirective;
 }
 
 @Component({
@@ -189,11 +189,11 @@ class ButtonWithAttribsComponent {
     `
 })
 class ButtonsWithDisplayDensityComponent {
-    @ViewChild('flat', { read: IgxButtonDirective, static: true }) flatButton: IgxButtonDirective;
-    @ViewChild('raised', { read: IgxButtonDirective, static: true }) raisedButton: IgxButtonDirective;
-    @ViewChild('outlined', { read: IgxButtonDirective, static: true }) outlinedButton: IgxButtonDirective;
-    @ViewChild('fab', { read: IgxButtonDirective, static: true }) fabButton: IgxButtonDirective;
-    @ViewChild('icon', { read: IgxButtonDirective, static: true }) iconButton: IgxButtonDirective;
+    @ViewChild('flat', { read: IgxButtonDirective, static: true }) public flatButton: IgxButtonDirective;
+    @ViewChild('raised', { read: IgxButtonDirective, static: true }) public raisedButton: IgxButtonDirective;
+    @ViewChild('outlined', { read: IgxButtonDirective, static: true }) public outlinedButton: IgxButtonDirective;
+    @ViewChild('fab', { read: IgxButtonDirective, static: true }) public fabButton: IgxButtonDirective;
+    @ViewChild('icon', { read: IgxButtonDirective, static: true }) public iconButton: IgxButtonDirective;
 
     public density: DisplayDensity = DisplayDensity.comfortable;
 }

projects/igniteui-angular/src/lib/directives/divider/divider.directive.ts

@@ -48,7 +48,7 @@ export class IgxDividerDirective {
     public type: IgxDividerType | string = IgxDividerType.SOLID;
 
     @HostBinding('class.igx-divider--dashed')
-    get isDashed() {
+    public get isDashed() {
         return this.type === IgxDividerType.DASHED;
     }
 
@@ -83,7 +83,7 @@ export class IgxDividerDirective {
      * ```
      */
     @HostBinding('style.margin')
-    set inset(value: string) {
+    public set inset(value: string) {
         this._inset = value;
     }
 
@@ -94,7 +94,7 @@ export class IgxDividerDirective {
      * const inset = this.divider.inset;
      * ```
      */
-    get inset() {
+    public get inset() {
         const baseMargin = '0';
 
         if (this.middle) {
@@ -127,7 +127,7 @@ export class IgxDividerDirective {
      * const isDefault = this.divider.isDefault;
      * ```
      */
-    get isSolid() {
+    public get isSolid() {
         return this.type === IgxDividerType.SOLID;
     }
 }