Skip to content

Commit ea38f66

Browse files
author
Borislav Kulov
committed
feat(igx-ragio-group): Rename the selector (#1610)
1 parent 33dd3c4 commit ea38f66

File tree

3 files changed

+21
-21
lines changed

3 files changed

+21
-21
lines changed

‎projects/igniteui-angular/src/lib/directives/radio/radio-group.directive.spec.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -180,11 +180,11 @@ describe('IgxRadioGroupDirective', () => {
180180
});
181181

182182
@Component({
183-
template: `<igx-radiogroup #radioGroup name="radioGroup" value="Baz" required="true" labelPosition="before">
183+
template: `<igx-radio-group #radioGroup name="radioGroup" value="Baz" required="true" labelPosition="before">
184184
<igx-radio *ngFor="let item of ['Foo', 'Bar', 'Baz']" value="{{item}}">
185185
{{item}}
186186
</igx-radio>
187-
</igx-radiogroup>
187+
</igx-radio-group>
188188
`
189189
})
190190
class RadioGroupComponent {
@@ -197,11 +197,11 @@ class Person {
197197
}
198198

199199
@Component({
200-
template: ` <igx-radiogroup #radioGroupSeasons name="radioGroupSeasons" [(ngModel)]="personBob.favoriteSeason">
200+
template: ` <igx-radio-group #radioGroupSeasons name="radioGroupSeasons" [(ngModel)]="personBob.favoriteSeason">
201201
<igx-radio *ngFor="let item of seasons" value="{{item}}">
202202
{{item}}
203203
</igx-radio>
204-
</igx-radiogroup>
204+
</igx-radio-group>
205205
`
206206
})
207207
class RadioGroupWithModelComponent {
@@ -220,11 +220,11 @@ class RadioGroupWithModelComponent {
220220
@Component({
221221
template: `
222222
<form [formGroup]="personForm">
223-
<igx-radiogroup formControlName="favoriteSeason" name="radioGroupReactive">
223+
<igx-radio-group formControlName="favoriteSeason" name="radioGroupReactive">
224224
<igx-radio *ngFor="let item of seasons" value="{{item}}">
225225
{{item}}
226226
</igx-radio>
227-
</igx-radiogroup>
227+
</igx-radio-group>
228228
</form>
229229
`
230230
})

‎projects/igniteui-angular/src/lib/directives/radio/radio-group.directive.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,15 @@ let nextId = 0;
1414
*
1515
* Example:
1616
* ```html
17-
* <igx-radiogroup name="radioGroup">
17+
* <igx-radio-group name="radioGroup">
1818
* <igx-radio *ngFor="let item of ['Foo', 'Bar', 'Baz']" value="{{item}}">
1919
* {{item}}
2020
* </igx-radio>
21-
* </igx-radiogroup>
21+
* </igx-radio-group>
2222
* ```
2323
*/
2424
@Directive({
25-
selector: 'igx-radiogroup, [igxRadioGroup]',
25+
selector: 'igx-radio-group, [igxRadioGroup]',
2626
providers: [{ provide: NG_VALUE_ACCESSOR, useExisting: IgxRadioGroupDirective, multi: true }]
2727
})
2828
export class IgxRadioGroupDirective implements AfterContentInit, ControlValueAccessor {
@@ -38,7 +38,7 @@ export class IgxRadioGroupDirective implements AfterContentInit, ControlValueAcc
3838
/**
3939
* Sets/gets the `value` attribute.
4040
* ```html
41-
* <igx-radiogroup [value] = "'radioButtonValue'"></igx-radiogroup>
41+
* <igx-radio-group [value] = "'radioButtonValue'"></igx-radio-group>
4242
* ```
4343
* ```typescript
4444
* let value = this.radioGroup.value;
@@ -57,7 +57,7 @@ export class IgxRadioGroupDirective implements AfterContentInit, ControlValueAcc
5757
/**
5858
* Sets/gets the `name` attribute of the radio group component. All child radio buttons inherits this name.
5959
* ```html
60-
* <igx-radiogroup name = "Radio1"></igx-radiogroup>
60+
* <igx-radio-group name = "Radio1"></igx-radio-group>
6161
* ```
6262
* ```typescript
6363
* let name = this.radioGroup.name;
@@ -77,7 +77,7 @@ export class IgxRadioGroupDirective implements AfterContentInit, ControlValueAcc
7777
* Sets/gets whether the radio group is required.
7878
* If not set, `required` will have value `false`.
7979
* ```html
80-
* <igx-radiogroup [required] = "true"></igx-radiogroup>
80+
* <igx-radio-group [required] = "true"></igx-radio-group>
8181
* ```
8282
* ```typescript
8383
* let isRequired = this.radioGroup.required;
@@ -96,7 +96,7 @@ export class IgxRadioGroupDirective implements AfterContentInit, ControlValueAcc
9696
/**
9797
* An @Input property that allows you to disable the radio group. By default it's false.
9898
* ```html
99-
* <igx-radiogroup [disabled]="true"></igx-radiogroup>
99+
* <igx-radio-group [disabled]="true"></igx-radio-group>
100100
* ```
101101
* @memberof IgxRadioGroupDirective
102102
*/
@@ -113,7 +113,7 @@ export class IgxRadioGroupDirective implements AfterContentInit, ControlValueAcc
113113
* Sets/gets the position of the `label` in the child radio buttons.
114114
* If not set, `labelPosition` will have value `"after"`.
115115
* ```html
116-
* <igx-radiogroup labelPosition = "before"></igx-radiogroup>
116+
* <igx-radio-group labelPosition = "before"></igx-radio-group>
117117
* ```
118118
* ```typescript
119119
* let labelPosition = this.radioGroup.labelPosition;

‎src/app/radio/radio.sample.html

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@
55
<section class="sample-content">
66
<article class="sample-column">
77
<h4 class="sample-title">Radio group without data model</h4>
8-
<igx-radiogroup #radioGroupZZ name="radiogroupZZ" value="Bar" required="true" (change)="onRadioChange($event)">
8+
<igx-radio-group #radioGroupZZ name="radiogroupZZ" value="Bar" required="true" (change)="onRadioChange($event)">
99
<igx-radio class="radio-sample" *ngFor="let item of ['Foo', 'Bar', 'Baz']" value="{{item}}">
1010
{{item}}
1111
</igx-radio>
12-
</igx-radiogroup>
12+
</igx-radio-group>
1313
<label>
1414
<input type="checkbox" [checked]="radioGroup.disabled" (change)="radioGroup.disabled = !radioGroup.disabled"> Disabled
1515
</label>
@@ -30,11 +30,11 @@ <h4 class="sample-title">Radio group in template-driven form</h4>
3030
</div>
3131
<div>
3232
<label for="radioGroupSeasons">Favorite season </label>
33-
<igx-radiogroup id="radioGroupSeasons" name="radioGroupSeasons" labelPosition="before" [(ngModel)]="personBob.favoriteSeason">
33+
<igx-- id="radioGroupSeasons" name="radioGroupSeasons" labelPosition="before" [(ngModel)]="personBob.favoriteSeason">
3434
<igx-radio class="radio-sample" *ngFor="let item of seasons" value="{{item}}">
3535
{{item}}
3636
</igx-radio>
37-
</igx-radiogroup>
37+
</igx-radio-group>
3838
</div>
3939

4040
{{diagnostic}}<br>
@@ -48,14 +48,14 @@ <h4 class="sample-title">Radio group in reactive form</h4>
4848
<input formControlName="name">
4949
</label>
5050
<br>
51-
<!-- TODO: igx-radiogroup is not working properly when hosted in label element
51+
<!-- TODO: igx-radio-group is not working properly when hosted in label element
5252
When the radio button label is clicked a click event on the first item is triggered -->
5353
<!-- <label>Favorite Season -->
54-
<igx-radiogroup formControlName="favoriteSeason" name="radioGroupReactive">
54+
<igx-radio-group formControlName="favoriteSeason" name="radioGroupReactive">
5555
<igx-radio class="radio-sample" *ngFor="let item of seasons" value="{{item}}">
5656
{{item}}
5757
</igx-radio>
58-
</igx-radiogroup>
58+
</igx-radio-group>
5959
<!-- </label> -->
6060
<br>
6161
<button igxButton type="button" (click)="onUpdateBtnClick($event)" style="width: 200px">Update model</button>

0 commit comments

Comments
 (0)