feat(stepper): add additional expectations

Author: ddaribo

projects/igniteui-angular/src/lib/stepper/stepper.component.spec.ts

@@ -203,40 +203,16 @@ describe('Rendering Tests', () => {
                 owner: stepper,
             };
 
-            stepper.navigateTo(null);
-            fix.detectChanges();
-            expect(changingSpy).not.toHaveBeenCalled();
-            expect(changedSpy).not.toHaveBeenCalled();
-            expect(serviceExpandSpy).not.toHaveBeenCalled();
-            expect(serviceCollapseSpy).not.toHaveBeenCalled();
-
-            stepper.navigateTo(undefined);
-            fix.detectChanges();
-            expect(changingSpy).not.toHaveBeenCalled();
-            expect(changedSpy).not.toHaveBeenCalled();
-            expect(serviceExpandSpy).not.toHaveBeenCalled();
-            expect(serviceCollapseSpy).not.toHaveBeenCalled();
-
-            stepper.navigateTo([] as any);
-            fix.detectChanges();
-            expect(changingSpy).not.toHaveBeenCalled();
-            expect(changedSpy).not.toHaveBeenCalled();
-            expect(serviceExpandSpy).not.toHaveBeenCalled();
-            expect(serviceCollapseSpy).not.toHaveBeenCalled();
-
-            stepper.navigateTo({} as any);
-            fix.detectChanges();
-            expect(changingSpy).not.toHaveBeenCalled();
-            expect(changedSpy).not.toHaveBeenCalled();
-            expect(serviceExpandSpy).not.toHaveBeenCalled();
-            expect(serviceCollapseSpy).not.toHaveBeenCalled();
+            const testValues = [null, undefined, [], {}, 'sampleString'];
 
-            stepper.navigateTo('sampleString' as any);
-            fix.detectChanges();
-            expect(changingSpy).not.toHaveBeenCalled();
-            expect(changedSpy).not.toHaveBeenCalled();
-            expect(serviceExpandSpy).not.toHaveBeenCalled();
-            expect(serviceCollapseSpy).not.toHaveBeenCalled();
+            for(const val of testValues){
+                stepper.navigateTo(val as any);
+                fix.detectChanges();
+                expect(changingSpy).not.toHaveBeenCalled();
+                expect(changedSpy).not.toHaveBeenCalled();
+                expect(serviceExpandSpy).not.toHaveBeenCalled();
+                expect(serviceCollapseSpy).not.toHaveBeenCalled();
+            }
 
             stepper.navigateTo(1);
             fix.detectChanges();
@@ -548,6 +524,16 @@ describe('Rendering Tests', () => {
 
             expect(stepper.animationDuration).toBe(1000);
 
+            fix.componentInstance.animationDuration = null;
+            fix.detectChanges();
+
+            expect(stepper.animationDuration).toBe((stepper as any)._defaultAnimationDuration);
+
+            fix.componentInstance.animationDuration = undefined;
+            fix.detectChanges();
+
+            expect(stepper.animationDuration).toBe((stepper as any)._defaultAnimationDuration);
+
             expect(stepper.horizontalAnimationType).toBe(fix.componentInstance.horizontalAnimationType);
             expect(stepper.horizontalAnimationType).toBe('slide');
 
@@ -643,7 +629,7 @@ describe('Rendering Tests', () => {
             fix.detectChanges();
 
             // if the dynamically added step's position is after the active step in linear mode,
-            // and this step is not valid, the added step should be linear disabled
+            // and the latter is not valid, the added step should be linear disabled
             stepper.steps[0].isValid = true;
             stepper.steps[1].isValid = false;
             stepper.steps[1].active = true;
@@ -1022,6 +1008,14 @@ describe('Stepper service unit tests', () => {
         expect(stepperService.activeStep).toBe(steps[0]);
         expect(steps[0].activeChange.emit).toHaveBeenCalledTimes(1);
         expect(steps[0].activeChange.emit).toHaveBeenCalledWith(true);
+
+        const testValues = [null, undefined, [], {}, 'sampleString'];
+
+        for(const val of testValues){
+            expect(() => {
+                stepperService.expand(val as any);
+            }).toThrow();
+        }
     });
 
     it('should expand a step through API by activating it and firing the step\'s activeChange event', () => {
@@ -1037,7 +1031,6 @@ describe('Stepper service unit tests', () => {
         stepperService.expandThroughApi(steps[1]);
 
         expect(stepperService.activeStep).toBe(steps[1]);
-
         expect(steps[0].activeChange.emit).toHaveBeenCalledTimes(1);
         expect(steps[0].activeChange.emit).toHaveBeenCalledWith(false);
         expect(steps[1].activeChange.emit).toHaveBeenCalledTimes(1);
@@ -1052,6 +1045,14 @@ describe('Stepper service unit tests', () => {
         expect(steps[1].activeChange.emit).toHaveBeenCalledWith(false);
         expect(steps[0].activeChange.emit).toHaveBeenCalledTimes(2);
         expect(steps[0].activeChange.emit).toHaveBeenCalledWith(true);
+
+        const testValues = [null, undefined, [], {}, 'sampleString'];
+
+        for(const val of testValues){
+            expect(() => {
+                stepperService.expandThroughApi(val as any);
+            }).toThrow();
+        }
     });
 
     it('should collapse the currently active step and fire the change event', () => {
@@ -1097,6 +1098,14 @@ describe('Stepper service unit tests', () => {
         expect(steps[1].activeChange.emit).toHaveBeenCalledTimes(1);
         expect(steps[1].activeChange.emit).toHaveBeenCalledWith(false);
         expect(steps[0].activeChange.emit).not.toHaveBeenCalledTimes(2);
+
+        const testValues = [null, undefined, [], {}, 'sampleString'];
+
+        for(const val of testValues){
+            expect(() => {
+                stepperService.collapse(val as any);
+            }).toThrow();
+        }
     });
 
     it('should determine the steps that are marked as visited based on the active step', () => {
@@ -1137,7 +1146,7 @@ describe('Stepper service unit tests', () => {
         expect(stepperService.linearDisabledSteps.size).toBe(0);
         stepperService.calculateLinearDisabledSteps();
         expect(stepperService.linearDisabledSteps.size).toBe(3);
-        let sampleSet: Set<IgxStepComponent> = new Set<IgxStepComponent>([steps[1], steps[2], steps[3]]);
+        let sampleSet = new Set<IgxStepComponent>([steps[1], steps[2], steps[3]]);
         expect(stepperService.linearDisabledSteps).toEqual(sampleSet);
 
         spyOnProperty(steps[0], 'isValid').and.returnValue(true);