Skip to content

Commit fad482d

Browse files
committed
refactor(time-picker): fix failing tests #6482
1 parent c82f73c commit fad482d

File tree

1 file changed

+14
-13
lines changed

1 file changed

+14
-13
lines changed

projects/igniteui-angular/src/lib/time-picker/time-picker.component.spec.ts

+14-13
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import { configureTestSuite } from '../test-utils/configure-suite';
1010
import { PickerInteractionMode } from '../date-common/types';
1111
import { IgxIconModule } from '../icon/public_api';
1212
import { IgxToggleDirective } from '../directives/toggle/toggle.directive';
13-
import { KEYS } from '../core/utils';
13+
import { PlatformUtil } from '../core/utils';
1414
import { DatePart } from '../directives/date-time-editor/public_api';
1515
import { DateTimeUtil } from '../date-common/util/date-time.util';
1616

@@ -41,7 +41,7 @@ describe('IgxTimePicker', () => {
4141
const mockDateTimeEditorDirective = jasmine.createSpyObj('IgxDateTimeEditorDirective', ['increment', 'decrement'], { value: null });
4242

4343
it('should open/close the dropdown with open()/close() method', () => {
44-
timePicker = new IgxTimePickerComponent(elementRef, null, null, null, mockInjector);
44+
timePicker = new IgxTimePickerComponent(elementRef, null, null, null, mockInjector, null);
4545
(timePicker as any).dateTimeEditor = mockDateTimeEditorDirective;
4646
const mockToggleDirective = jasmine.createSpyObj('IgxToggleDirective', ['open', 'close'], { collapsed: true });
4747
(timePicker as any).toggleRef = mockToggleDirective;
@@ -56,7 +56,7 @@ describe('IgxTimePicker', () => {
5656
});
5757

5858
it('should open/close the dropdown with toggle() method', () => {
59-
timePicker = new IgxTimePickerComponent(elementRef, null, null, null, mockInjector);
59+
timePicker = new IgxTimePickerComponent(elementRef, null, null, null, mockInjector, null);
6060
(timePicker as any).dateTimeEditor = mockDateTimeEditorDirective;
6161
const mockToggleDirective = jasmine.createSpyObj('IgxToggleDirective', ['open', 'close'], { collapsed: true });
6262
(timePicker as any).toggleRef = mockToggleDirective;
@@ -71,7 +71,7 @@ describe('IgxTimePicker', () => {
7171
});
7272

7373
it('should reset value and emit valueChange with clear() method', () => {
74-
timePicker = new IgxTimePickerComponent(elementRef, null, null, null, null);
74+
timePicker = new IgxTimePickerComponent(elementRef, null, null, null, null, null);
7575
(timePicker as any).dateTimeEditor = mockDateTimeEditorDirective;
7676
const mockToggleDirective = jasmine.createSpyObj('IgxToggleDirective', { collapsed: true });
7777
(timePicker as any).toggleRef = mockToggleDirective;
@@ -96,7 +96,7 @@ describe('IgxTimePicker', () => {
9696
});
9797

9898
it('should not emit valueChange when value is \'00:00:00\' and is cleared', () => {
99-
timePicker = new IgxTimePickerComponent(elementRef, null, null, null, null);
99+
timePicker = new IgxTimePickerComponent(elementRef, null, null, null, null, null);
100100
(timePicker as any).dateTimeEditor = mockDateTimeEditorDirective;
101101
const mockToggleDirective = jasmine.createSpyObj('IgxToggleDirective', { collapsed: true });
102102
(timePicker as any).toggleRef = mockToggleDirective;
@@ -112,7 +112,7 @@ describe('IgxTimePicker', () => {
112112
});
113113

114114
it('should not emit valueChange when value is null and is cleared', () => {
115-
timePicker = new IgxTimePickerComponent(elementRef, null, null, null, null);
115+
timePicker = new IgxTimePickerComponent(elementRef, null, null, null, null, null);
116116
(timePicker as any).dateTimeEditor = mockDateTimeEditorDirective;
117117
const mockToggleDirective = jasmine.createSpyObj('IgxToggleDirective', { collapsed: true });
118118
(timePicker as any).toggleRef = mockToggleDirective;
@@ -125,7 +125,7 @@ describe('IgxTimePicker', () => {
125125
});
126126

127127
it('should select time and trigger valueChange event with select() method', () => {
128-
timePicker = new IgxTimePickerComponent(elementRef, null, null, null, null);
128+
timePicker = new IgxTimePickerComponent(elementRef, null, null, null, null, null);
129129
(timePicker as any).dateTimeEditor = mockDateTimeEditorDirective;
130130

131131
const date = new Date(2020, 12, 12, 10, 30, 30);
@@ -141,7 +141,7 @@ describe('IgxTimePicker', () => {
141141
});
142142

143143
it('should fire vallidationFailed on selecting time outside min/max range', () => {
144-
timePicker = new IgxTimePickerComponent(elementRef, null, null, null, null);
144+
timePicker = new IgxTimePickerComponent(elementRef, null, null, null, null, null);
145145
(timePicker as any).dateTimeEditor = mockDateTimeEditorDirective;
146146

147147
const date = new Date(2020, 12, 12, 10, 30, 30);
@@ -162,7 +162,7 @@ describe('IgxTimePicker', () => {
162162
});
163163

164164
xit('should change date parts correctly with increment() and decrement() methods', () => {
165-
timePicker = new IgxTimePickerComponent(elementRef, null, null, null, null);
165+
timePicker = new IgxTimePickerComponent(elementRef, null, null, null, null, null);
166166
(timePicker as any).dateTimeEditor = mockDateTimeEditorDirective;
167167

168168
const date = new Date(2020, 12, 12, 10, 30, 30);
@@ -202,7 +202,8 @@ describe('IgxTimePicker', () => {
202202
IgxInputGroupModule,
203203
IgxIconModule,
204204
FormsModule,
205-
NoopAnimationsModule]
205+
NoopAnimationsModule],
206+
providers: [PlatformUtil]
206207
}).compileComponents();
207208
}));
208209
beforeEach(fakeAsync(() => {
@@ -280,7 +281,7 @@ describe('IgxTimePicker', () => {
280281
}));
281282

282283
it('should open/close the dropdown and keep the current selection on Space/Enter key press', fakeAsync(() => {
283-
UIInteractions.triggerKeyDownEvtUponElem(KEYS.SPACE, input.nativeElement, true);
284+
UIInteractions.triggerKeyDownEvtUponElem('Space', input.nativeElement, true);
284285
tick();
285286
fixture.detectChanges();
286287
expect(toggleDirective.collapsed).toBeFalsy();
@@ -289,7 +290,7 @@ describe('IgxTimePicker', () => {
289290
hourColumn.triggerEventHandler('wheel', event);
290291
fixture.detectChanges();
291292

292-
UIInteractions.triggerKeyDownEvtUponElem(KEYS.ENTER, hourColumn.nativeElement);
293+
UIInteractions.triggerKeyDownEvtUponElem('Enter', hourColumn.nativeElement);
293294
tick();
294295
fixture.detectChanges();
295296
expect(toggleDirective.collapsed).toBeTruthy();
@@ -316,7 +317,7 @@ describe('IgxTimePicker', () => {
316317
const selectedHour = fixture.componentInstance.date.getHours() - 3;
317318
expect((timePicker.value as Date).getHours()).toEqual(selectedHour);
318319

319-
UIInteractions.triggerKeyDownEvtUponElem(KEYS.ESCAPE, input.nativeElement, true);
320+
UIInteractions.triggerKeyDownEvtUponElem('Escape', input.nativeElement, true);
320321
tick();
321322
fixture.detectChanges();
322323
expect(toggleDirective.collapsed).toBeTruthy();

0 commit comments

Comments
 (0)