Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support height for card component #12555

Closed
ig-georgeA opened this issue Jan 20, 2023 · 0 comments · Fixed by #12574
Closed

Support height for card component #12555

ig-georgeA opened this issue Jan 20, 2023 · 0 comments · Fixed by #12574
Assignees
@simeonoff
Labels
🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@ig-georgeA
Copy link

ig-georgeA commented Jan 20, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

In the current version, the height of the card is determined by its content. This by itself is fine, but also creates a problem when multiple cards are added to a flex container (flex-direction: row) and bound to data. You end up with cards with different heights and no way to give them the same height. Moreover, setting align-items:stretch will have no effect.

image

Even if we manually add a height via CSS, the card content area does not look right.
image

Describe the solution you'd like

Card should support height, and when resizing, position content as expected. That is, card-actions remain anchored to the bottom, and the rest stay put.

Describe alternatives you've considered

My solution may not be accurate as I'm not that experienced with web-layouts. So any alternate suggestions are welcome.

Additional context

Add any other context or screenshots about the feature request here.
@simeonoff simeonoff self-assigned this Jan 23, 2023
@simeonoff simeonoff added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Jan 24, 2023
simeonoff added a commit that referenced this issue Jan 24, 2023
@simeonoff
feat(card): correctly size when height changes
5203feb 
Closes #12555
@simeonoff simeonoff mentioned this issue Jan 24, 2023
Merged
14 tasks
@simeonoff simeonoff added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jan 24, 2023
simeonoff added a commit that referenced this issue Feb 1, 2023
@simeonoff @SisIvanova
feat(card): correctly size when height changes (#12574)
66ecef5 
* feat(card): correctly size when height changes
Closes #12555

* refactor(card): fix vertical card action margins

---------

Co-authored-by: Silvia Ivanova <[email protected]>
@ig-georgeA ig-georgeA mentioned this issue Apr 10, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simeonoff simeonoff

Labels
🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(card): correctly size when height changes IgniteUI/igniteui-angular
2 participants
@simeonoff @ig-georgeA