Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSR Grid Improvements #15202

Closed
ChronosSF opened this issue Jan 6, 2025 · 5 comments · Fixed by #15556
Closed

SSR Grid Improvements #15202

ChronosSF opened this issue Jan 6, 2025 · 5 comments · Fixed by #15556
Assignees
Labels
angular: ssr 📈 enhancement grid ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@ChronosSF
Copy link
Member

When in SSR mode (or prerender) the correct behavior of the grid should be:

  • render all elements declared in the template
  • do not change sizes (% width should render as % width)
  • render all defined columns without virtualization (auto-sizing should work as it does if there is no data)
  • render empty grid template or loading indicator based on options
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Mar 10, 2025
@radomirchev radomirchev removed the status: inactive Used to stale issues and pull requests label Mar 12, 2025
@MayaKirova
Copy link
Contributor

@ChronosSF I have some questions:

  • What do you mean by "render all elements declared in the template"? Which template? Can you give an example?
  • Should the grid render empty for all grid size configurations or just for width/height 100%? For example, if I have a grid with set width/height in px and I can calculate and render everything I need on the server, should I still disable virtualization and render the grid initially empty with all columns?

@MayaKirova
Copy link
Contributor

@ChronosSF @dkamburov I've added notes on SSR in the spec here for height and here for width. Please approve.

@ChronosSF
Copy link
Member Author

@ChronosSF I have some questions:

  • What do you mean by "render all elements declared in the template"? Which template? Can you give an example?
  • Should the grid render empty for all grid size configurations or just for width/height 100%? For example, if I have a grid with set width/height in px and I can calculate and render everything I need on the server, should I still disable virtualization and render the grid initially empty with all columns?
  • it means it should have the toolbar rendered, the paginator rendered and anything else that you put as additional components in the grid
  • if the grid has pixel width/heights unless there is some limitation that I am not aware of, we can render the data with virtualization server-side. If we can then we should.

@dkamburov
Copy link
Contributor

I agree with the current notes and I believe they apply for the % scenario only, right?

Maybe additional note about what Stamen mentioned(altough this is how it currently behaves we don't need to add up to this scenario):

  • if the grid has pixel width/heights unless there is some limitation that I am not aware of, we can render the data with virtualization server-side. If we can then we should.

@radomirchev radomirchev added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Mar 24, 2025
@dkamburov dkamburov added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Mar 26, 2025
@mddragnev mddragnev added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed ❌ status: awaiting-test PRs awaiting manual verification labels Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular: ssr 📈 enhancement grid ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants