Skip to content

igxTreeGrid + Row Pinning issues #7141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
10 tasks done
ChronosSF opened this issue Apr 15, 2020 · 0 comments
Closed
10 tasks done

igxTreeGrid + Row Pinning issues #7141

ChronosSF opened this issue Apr 15, 2020 · 0 comments

Comments

@ChronosSF
Copy link
Member

ChronosSF commented Apr 15, 2020

  • Selection is still disabled for ghost rows (to be tested in IgxGrid disabled row implementation. #7104)
  • Pinning a root record changes summary result which means the summary pipe probably doesn't work correctly with pinned records
  • Export to csv exports pinned records with empty values
  • IMO filtered out rows that appear only because they are related to filtered in rows should not show they are pinned (because their pinned counterparts are not there Treegrid Pinned Row & Filtering #7172
  • When setting the pinned property of the TreeGridRow an error is thrown: Cannot set property pinned of [object Object] which has only a getter. You can still pin/unpin via the methods. - fix(igxTreeGrid): Overwrite setter as well as the getter. #7194
  • TreeGrid does not retain the order in which the rows are pinned but instead applies the original order from the data source to the pinned area. For example if you pin the second row and then first one, the pinned rows should be in order [2, 1], but are instead in order [1, 2]. - Fixes Wrong Order of Pinned Records in Treegrid #7216
  • Search - Result item count is incorrect if a row that does not have matching results is pinned. Can be reproduced by searching by an unique value that exist in just 1 row and then pinning some other unrelated row. The count is 2, however only 1 match exists. - feat(igxGrid): Update navigation to include ghost rows. #7148
  • Search - Result item count is incorrect (doubled) and navigation between matches does not work if a row is pinned. - feat(igxGrid): Update navigation to include ghost rows. #7148
    Can be reproduced by searching by a value that exists once in every row, observe the matches count, then clear search and pin any row and apply same search value and observe that now the match count is doubled. Nothing seems to be marked as active when you use findNext/findPrev.
  • filteredSortedData is incorrect - feat(igxGrid): Update navigation to include ghost rows. #7148

treegrid-search

image

@3phase 3phase added the 🛠️ status: in-development Issues and PRs with active development on them label Apr 15, 2020
@ChronosSF ChronosSF added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. 🛠️ status: in-development Issues and PRs with active development on them and removed 🛠️ status: in-development Issues and PRs with active development on them ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. labels Apr 16, 2020
@ChronosSF ChronosSF added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Apr 22, 2020
@MayaKirova MayaKirova removed the ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. label Apr 22, 2020
@ChronosSF ChronosSF added the 🛠️ status: in-development Issues and PRs with active development on them label Apr 22, 2020
@MayaKirova MayaKirova self-assigned this Apr 23, 2020
@ChronosSF ChronosSF removed the 🛠️ status: in-development Issues and PRs with active development on them label Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants