Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

igxGrid default column display templates per-type #7224

Closed
kdinev opened this issue Apr 28, 2020 · 0 comments · Fixed by #7823
Closed

igxGrid default column display templates per-type #7224

kdinev opened this issue Apr 28, 2020 · 0 comments · Fixed by #7823
Assignees
Labels
grid: column-types grid: general size: M specification 🧰 feature-request version: 10.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@kdinev
Copy link
Member

kdinev commented Apr 28, 2020

Is your feature request related to a problem? Please describe.

Currently, the igx-grid exposes default handling for column types like number - right aligned, string - left aligned, date. This should be expanded to better defaults for other column types.

Describe the solution you'd like

I would like to have the boolean columns display check and empty or check and X, instead of true/false by default.

Describe alternatives you've considered

I can provide my own template for boolean columns with igx-icon.

Additional context

This simplifies that igx-grid setup for better support of the 80% scenarios.

@Aleksandyr Aleksandyr added the 🛠️ status: in-development Issues and PRs with active development on them label Jul 2, 2020
@simeonoff simeonoff self-assigned this Jul 20, 2020
zdrawku added a commit that referenced this issue Jul 27, 2020
* feat(grid): expose bool default template Closes #7224

* feat(grid-cell): exposing default template tick class

* style(grid): add styles for boolean column

* fix(grid-cell): change bool icon class

* fix(grid): move bool icon template otside the text wrapper

* fix(grid): move default template class on the host

* feat(grid): add missed underscore

* style(grid): add styles for the new template

* style(grid): move placeholder selector separately

* fix(grid): remove cell value interpolation space

* feat(grid): expose bool default template in hgrid cell

* chore(*): Changelog update

Co-authored-by: didimmova <[email protected]>
Co-authored-by: Simeon Simeonoff <[email protected]>
Co-authored-by: Zdravko Kolev <[email protected]>
zdrawku added a commit that referenced this issue Jul 27, 2020
* feat(grid): expose bool default template Closes #7224

* feat(grid-cell): exposing default template tick class

* style(grid): add styles for boolean column

* fix(grid-cell): change bool icon class

* fix(grid): move bool icon template otside the text wrapper

* merge

* feat(grid): add missed underscore

* style(grid): add styles for the new template

* style(grid): move placeholder selector separately

* merge

* merge

* merge

* fix(grid): revert cells state to not include nested props formatting

* fix(grid): revert row pipe triggers

Co-authored-by: didimmova <[email protected]>
Co-authored-by: Zdravko Kolev <[email protected]>
Co-authored-by: Simeon Simeonoff <[email protected]>
@zdrawku zdrawku added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment