Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datetime or Time in avaliable type of column #7678

Closed
ssg127 opened this issue Jun 25, 2020 · 11 comments · Fixed by #9334
Closed

Datetime or Time in avaliable type of column #7678

ssg127 opened this issue Jun 25, 2020 · 11 comments · Fixed by #9334
Assignees
@zdrawku @ddincheva @radomirchev
Labels
filtering 🧨 severity: medium grid: column-types grid: excel-style-filtering grid: general program: igniteui project management 🧰 feature-request version: 9.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@ssg127
Copy link

ssg127 commented Jun 25, 2020

DESCRIPTION

It is necessary to be able to have time columns, either an independent column or integrating it with the date column.

With the current functionality, the column can be formatted, but when using excelStyleFilter in the select the time always goes to 0 and cannot be filtered taking into account the hours. A timePicker should be used.

EXAMPLE

image

SOLUTION

The solution is to create a new datatype, either DateTime or Time and then use date-time-picker or time-picker.
@ssg127
Copy link
Author

ssg127 commented Jul 16, 2020

Nothing? This is a very useful thing and easy to develop I think.

@kdinev
Copy link
Member

kdinev commented Jul 24, 2020

@ssg127 This actually looks like a bug to me. I changed the labels to reflect that. Can you tell us which version you're using?

@ssg127
Copy link
Author

ssg127 commented Jul 27, 2020

@kdinev I've seen this error with all versions I've tried, but now, I have two projects, one with 8.2.29 and another with 9.0.20. I used to try new versions but the error is always present.

Anyway, I think a datetime or time column-type is more useful so that it can also be filtered by time, that's why I added the feature-request label. Correcting the format might be a partial solution, but a new column is better.

@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Sep 26, 2020
@kdinev kdinev removed the status: inactive Used to stale issues and pull requests label Sep 26, 2020
@zdrawku zdrawku added 🧰 feature-request grid: column-types and removed 🐛 bug Any issue that describes a bug labels Oct 9, 2020
@zdrawku zdrawku mentioned this issue Oct 9, 2020
Closed
@github-actions
Copy link

github-actions bot commented Dec 9, 2020

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Dec 9, 2020
@ssg127
Copy link
Author

ssg127 commented Dec 9, 2020

Any news about this change?

@kdinev
Copy link
Member

kdinev commented Dec 9, 2020

@ssg127 We haven't gotten to implementing a time type of column.

@zdrawku @radomirchev When do you think this can be prioritized?

@radomirchev radomirchev removed the status: inactive Used to stale issues and pull requests label Dec 14, 2020
@zdrawku
Copy link
Contributor

zdrawku commented Jan 14, 2021

We are adding this feature in the current Milestone 15 planning - it will be considered along with Percent and Currency type columns.

@radomirchev radomirchev added the program: igniteui project management label Jan 19, 2021
@ssg127
Copy link
Author

ssg127 commented Feb 17, 2021

@zdrawku I have seen that you have closed the related issue. Will this be included in the next version?

@kdinev
Copy link
Member

kdinev commented Feb 17, 2021

@ssg127 The related issue was about Percent and Currency type columns. The time column goes in development now, since the percent and currency are already done. @zdrawku

@zdrawku zdrawku added the 🛠️ status: in-development Issues and PRs with active development on them label Mar 26, 2021
ddincheva added a commit that referenced this issue Apr 15, 2021
@ddincheva
feat(IgxCell): initial implementation of time and dateTime columns #7678
d4014e5
ddincheva added a commit that referenced this issue Apr 15, 2021
@ddincheva
feat(*): add sorting for time colimn #7678
809a01f
ddincheva added a commit that referenced this issue Apr 15, 2021
@ddincheva
feat(filtering): add resources for time and dateTime columns in filte…
35392d6 
…ring #7678
ddincheva added a commit that referenced this issue Apr 15, 2021
@ddincheva
feat(advancedFiltering): add filter template for time and dateTime co…
898bc9f 
…lumns #7678
ddincheva added a commit that referenced this issue Apr 15, 2021
@ddincheva
feat(Filtering): add filter template for time and dateTime columns #7678
c7f92f6
ddincheva added a commit that referenced this issue Apr 15, 2021
@ddincheva
feat(Summary): add summary operand fot time column #7678
70fbb8c
ddincheva added a commit that referenced this issue Apr 15, 2021
@ddincheva
feat(Filtering): add filtering conditions for time and dateTime columns
f7f68e7 
#7678
ddincheva added a commit that referenced this issue Apr 15, 2021
@ddincheva
fix(filtering): filter data correctly #7678
371c004
@ddincheva ddincheva mentioned this issue Apr 15, 2021
Merged
14 tasks
@zdrawku zdrawku added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Apr 16, 2021
ddincheva added a commit that referenced this issue Apr 16, 2021
@ddincheva
fix(IgxGrid): fix overlay warnings thrown on scroll #7678
59ec60b
zdrawku added a commit that referenced this issue Apr 17, 2021
@ddincheva @zdrawku
Add time and date time column types (#9334)
d860375 
* feat(IgxCell): initial implementation of time and dateTime columns #7678

* feat(*): add sorting for time colimn #7678

* chore(*): update moving sample to have time and dateTime columns

* feat(filtering):  add resources for time and dateTime columns in filtering #7678

* feat(advancedFiltering): add filter template for time and dateTime columns #7678

* feat(Filtering): add filter template for time and dateTime columns #7678

* feat(Summary): add summary operand fot time column #7678

* feat(Filtering): add filtering conditions for time and dateTime columns #7678

* fix(filtering): filter data correctly #7678

* chore(*): fix build problem

* chore(*): fix tree grid fitering strategy

* chore(*): address testing comments

* chore(IgxCell): fix editing for time columns

* fix(IgxGrid): fix overlay warnings thrown on scroll #7678

* chore(*): Add test for filtering condition

* chore(*): Fix expect's for +2 new columns

* chore(*): add +2 new columns

* chore(*): Fix flickering test with kb navigation

* chore(*): Remove redundant getDateParts

* chore(*): Add dateTime filtering conditions

Co-authored-by: Zdravko Kolev <[email protected]>
ddincheva added a commit that referenced this issue Apr 22, 2021
@ddincheva
fix(filtering): apply filtering correctly on dateTime and time columns …
9e4979c 
…#7678
@ssg127
Copy link
Author

ssg127 commented Apr 26, 2021

I have another question, the excelStyleFilter will allow to filter by time or only by date as before? I speak about datetime columns or time columns.

@radomirchev radomirchev mentioned this issue Jun 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zdrawku zdrawku

@ddincheva ddincheva

@radomirchev radomirchev

Labels
filtering 🧨 severity: medium grid: column-types grid: excel-style-filtering grid: general program: igniteui project management 🧰 feature-request version: 9.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add time and date time column types IgniteUI/igniteui-angular
5 participants
@kdinev @zdrawku @ddincheva @ssg127 @radomirchev