Skip to content

Move PositionSettings to OverlaySettings #7807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wnvko opened this issue Jul 17, 2020 · 1 comment · Fixed by #8099
Closed

Move PositionSettings to OverlaySettings #7807

wnvko opened this issue Jul 17, 2020 · 1 comment · Fixed by #8099
Assignees
@Lipata @PlamenaMiteva
Labels
🧨 severity: medium overlay size: L 🧰 feature-request version: 10.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@wnvko
Copy link
Contributor

wnvko commented Jul 17, 2020

Is your feature request related to a problem? Please describe.

Providing a simple change to OverlaySettings and merge the change to existing settings is really hard now. A flat structure will make this a lot simpler.

Describe the solution you'd like

Has all the settings IgxOverlayService need in its OverlaySettings

Describe alternatives you've considered

Additional context
@Lipata Lipata added the size: M label Aug 11, 2020
@Lipata Lipata added size: L and removed size: M labels Aug 20, 2020
@Lipata Lipata assigned Lipata and PlamenaMiteva and unassigned Lipata and wnvko Aug 21, 2020
@PlamenaMiteva PlamenaMiteva added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Sep 3, 2020
PlamenaMiteva added a commit that referenced this issue Sep 8, 2020
@PlamenaMiteva
feat(overlay): move target to overlaySettings #7807
2129d9f
@PlamenaMiteva PlamenaMiteva mentioned this issue Sep 8, 2020
Merged
14 tasks
@PlamenaMiteva PlamenaMiteva added 🆕 status: new and removed 🛠️ status: in-development Issues and PRs with active development on them labels Sep 14, 2020
@Lipata Lipata added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🆕 status: new labels Sep 14, 2020
PlamenaMiteva added a commit that referenced this issue Sep 17, 2020
@PlamenaMiteva
feat(overlay): move target to overlaySettings #7807
ff5390a
@PlamenaMiteva
Copy link
Contributor

Since the most common issue our clients face is changing the target of the Position settings, which then requires the strategy settings overriding we have moved the target property to overlay settings. This will now make it easier for the target to be changed without the need to alter/override the position settings every time.

Lipata pushed a commit that referenced this issue Sep 21, 2020
@PlamenaMiteva
feat(overlay): move target to overlaySettings #7807 (#8099)
8fe7bd1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lipata Lipata

@PlamenaMiteva PlamenaMiteva

Labels
🧨 severity: medium overlay size: L 🧰 feature-request version: 10.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(overlay): move target to overlaySettings IgniteUI/igniteui-angular
3 participants
@Lipata @wnvko @PlamenaMiteva