Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A small badge option #8188

Closed
YoannaIvanova opened this issue Sep 23, 2020 · 1 comment · Fixed by #8460
Closed

A small badge option #8188

YoannaIvanova opened this issue Sep 23, 2020 · 1 comment · Fixed by #8460
Assignees
Labels
badge Badge component 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@YoannaIvanova
Copy link

Is your feature request related to a problem? Please describe.

I found it difficult to use the current badge size in combination with an avatar on mobile because it looks unnecessarily large for this case.

Describe the solution you'd like

In addition to the current badge, there should be a smaller badge size, which will be useful for better coverage of other scenarios.

Additional context

image
image
image

@SisIvanova SisIvanova self-assigned this Oct 26, 2020
@SisIvanova SisIvanova added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Oct 26, 2020
@SisIvanova SisIvanova added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Oct 26, 2020
@simeonoff
Copy link
Collaborator

@YoannaIvanova The attached PR allows you to define custom sizes via additional style rules applied to the badge. We decided to simplify the internal implementation of the badge to allow for robust badge styling, rather than just limit you to size options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
badge Badge component 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants