-
Notifications
You must be signed in to change notification settings - Fork 160
Which properties or features IgxGrid will not persist over RouteReuseStrategy? #8272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@ymita After some extensive testing, it seems that only properties related to column width are changing. Everything else seems to work correctly and no other grid properties are being mutated. We've tested with all a flat grid, hierarchical grid, and tree grid. All grids had all features enabled and tested before changing the route. The state tree was dumped before and after returning to the grid component view. After that we've compared the state tree dumps to find no changes to the properties on the grid instances. The column widths and scroll position are bugs/missing implementation, rather than the state not being "restored". |
@simeonoff I am asking this because this issue has been moved to Development. On the other hand, based on the information below, this is an issue with Angular framework and we will wait for the issue to be fixed by Angular framework. |
If @ChronosSF could chime in? |
We only moved the research issue to development. Any development for solving this on our end is in the ice box (#8145) Even if angular provides better hooks to let users know when something gets attached back, it's still going to be up to the developer to call, lets say grid.navigateTo(0) to reset the broken scroll state. However, a mutation observer could solve this completely, however, it's not up to me if we should implement one as it comes with certain performance implications especially on IE . It will however let us fix all projected content issues that people have with let's say tabs as well (#8285) @damyanpetev or @rkaraivanov, @kdinev may chime in if they want to. |
@ChronosSF Due to the performance implications of the potential fix, I think it's best if we just mark this as not supported. |
Well I am up for a mutation observer, because as you've said this can potentially fix a swath of content projection bugs. |
Description
Which properties or features IgxGrid will not persist over RouteReuseStrategy? So far, scroll position and column width are not restored as same as before. If other properties or features are not restored, would you let me know?
This is related to #8145
Following is an example that does not persist over RouteReuseStrategy.
Steps to reproduce
Result
Column width turns to be pixel from percent.
Expected result
Column width remains in percent.
Attachments
igx-grid-scroll-position-20201005.zip
The text was updated successfully, but these errors were encountered: