Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the way igxGrid allows using the igxPaginator #9097

Closed
4 tasks
hanastasov opened this issue Mar 2, 2021 · 0 comments · Fixed by #9808
Closed
4 tasks

Change the way igxGrid allows using the igxPaginator #9097

hanastasov opened this issue Mar 2, 2021 · 0 comments · Fixed by #9808
Assignees
Labels
grid: paging paginator program: igniteui project management 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@hanastasov
Copy link
Contributor

hanastasov commented Mar 2, 2021

Is your feature request related to a problem? Please describe.

Currently, the igx-paginator can be used as paginator for the igx-grid, but this comes with no integration. As a developer, I should be able to put the igx-paginator inside the igx-grid, and this should be enough for the paging to work (meaning the paginator and the grid are synced).

All paging properties related properties exposed by the grid should be deprecated, or made private, as they are duplicates of the same paginator properties.

If deprecated or hidden, think of how to resolve the

If any of these properties/inputs/outputs/methods should be used, the developer should use it through the igx-paginator.

Describe the solution you'd like

    <igx-grid #grid1 [data]="data | async">
        <igx-paginator #paginator
            [totalRecords]="totalCount"
            [(page)]="page"
            [(perPage)]="perPage"
            [selectLabel]="'Records per page:'"
            [selectOptions]="selectOptions"
            [displayDensity]="grid1.displayDensity"
            (pageChange)="paginate($event)"
            (perPageChange)="perPageChange($event)">
        </igx-paginator>
    </igx-grid>

Additional issues

#8914

  • Verify setting the page to a value different from 0 will work
  • Currently, the IgxGridPagingPipe uses page and perPage grid properties values to slice the data correctly. This should be handled, if these gets deprecatd/hidden.
  • Any other refactoring needed in the IgxGridPagingPipe - for example think of removing the grid.pagingState entirely, as it only seems to serve for getting the totalCountr number, and is used by the state directive.
  • Expose paging event
@radomirchev radomirchev added the program: igniteui project management label Mar 25, 2021
@ddincheva ddincheva self-assigned this May 20, 2021
@zdrawku zdrawku added the 🛠️ status: in-development Issues and PRs with active development on them label May 26, 2021
@ddincheva ddincheva added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid: paging paginator program: igniteui project management 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants