Skip to content

IgxDateRangeComponent implementation #7018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 136 commits into from
Apr 30, 2020
Merged

IgxDateRangeComponent implementation #7018

merged 136 commits into from
Apr 30, 2020

Conversation

jackofdiamond5
Copy link
Member

@jackofdiamond5 jackofdiamond5 commented Mar 30, 2020 •
edited by Lipata
Loading

Closes #5732, closes #7102

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@jackofdiamond5 jackofdiamond5 added the 🛠️ status: in-development Issues and PRs with active development on them label Mar 30, 2020
@jackofdiamond5 jackofdiamond5 requested a review from Lipata March 30, 2020 13:55
@Lipata Lipata mentioned this pull request Apr 10, 2020
Closed
ViktorSlavov
ViktorSlavov suggested changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@ViktorSlavov ViktorSlavov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment on the overlaySettings and some questions about the emitters. These will probably be addressed, as this is still in development, but wanted to have these present on the PR

IvayloG and others added 13 commits April 15, 2020 12:21
@IvayloG
chore(daterange): Add default ARIA #5732
b93e789
@Lipata
feat(igx-date-range): add localization #5732
3f809a5
@IvayloG
test(daterange): Add ARIA test #5732
b135d4e
@IvayloG
Merge branch 'bpenkov/igx-date-range' of https://github.com/IgniteUI/…
b6ecff2 
…igniteui-angular into iganchev/date-range-aria
@jackofdiamond5
feat(date-range): prefix/suffix directives; streamline display format…
a7e38af 
…ting #5732
@ViktorSlavov @jackofdiamond5
docs(date-range): update API snippets
01bd4ca
@ViktorSlavov @jackofdiamond5
refactor(date-range): remove export of non-public date-single compo…
b352aef 
…nent
@IvayloG @jackofdiamond5
chore(daterange): Add default ARIA #5732
9f855f2
@IvayloG @jackofdiamond5
test(daterange): Add ARIA test #5732
8d25cce
@Lipata @jackofdiamond5
feat(igx-date-range): add localization #5732
5936013
@IvayloG @jackofdiamond5
Merge branch 'bpenkov/igx-date-range' of https://github.com/IgniteUI/…
d4ae0a8 
…igniteui-angular into iganchev/date-range-aria
@jackofdiamond5
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular …
20349cd 
…into bpenkov/igx-date-range
@jackofdiamond5
feat(date-range): implementation #6271
c23724d
@jackofdiamond5 jackofdiamond5 force-pushed the bpenkov/igx-date-range branch from b6ecff2 to c23724d Compare April 21, 2020 12:10
wnvko and others added 2 commits April 21, 2020 16:31
@wnvko
Merge branch 'bpenkov/igx-date-range' of https://github.com/IgniteUI/…
0400daf 
…igniteui-angular into bpenkov/igx-date-range

# Conflicts:
#	projects/igniteui-angular/src/lib/date-range/igx-date-range-inputs.common.ts
#	projects/igniteui-angular/src/lib/date-range/igx-date-range.component.html
#	projects/igniteui-angular/src/lib/date-range/igx-date-range.component.spec.ts
#	projects/igniteui-angular/src/lib/date-range/igx-date-range.component.ts
#	projects/igniteui-angular/src/lib/date-range/igx-date-range.module.ts
#	projects/igniteui-angular/src/public_api.ts
#	src/app/date-range/date-range.sample.html
#	src/app/date-range/date-range.sample.scss
@Lipata
Merge branch 'master' into bpenkov/igx-date-range
460f075
@Lipata Lipata marked this pull request as ready for review April 21, 2020 13:38
@wnvko wnvko self-requested a review April 30, 2020 11:52
wnvko
wnvko previously approved these changes Apr 30, 2020
View reviewed changes
@wnvko wnvko force-pushed the bpenkov/igx-date-range branch from 7382fd5 to f163995 Compare April 30, 2020 12:08
@wnvko wnvko self-requested a review April 30, 2020 12:08
wnvko
wnvko previously approved these changes Apr 30, 2020
View reviewed changes
@Lipata Lipata requested review from Lipata, ViktorSlavov and wnvko April 30, 2020 15:52
@Lipata Lipata added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Apr 30, 2020
@Lipata Lipata merged commit 19e759f into master Apr 30, 2020
@Lipata Lipata deleted the bpenkov/igx-date-range branch April 30, 2020 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damyanpetev damyanpetev damyanpetev left review comments

@Lipata Lipata Lipata approved these changes

@wnvko wnvko wnvko approved these changes

@ViktorSlavov ViktorSlavov ViktorSlavov approved these changes

@simeonoff simeonoff simeonoff left review comments

Assignees

@Lipata Lipata

Labels
📅 date-range-picker squash-merge Merge PR with "Squash and Merge" option version: 9.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Styling for igx-range-date-picker Range selection for datepicker
8 participants
@jackofdiamond5 @Lipata @damyanpetev @simeonoff @wnvko @ViktorSlavov @IvayloG @PlamenaMiteva