Skip to content

[Bug] Calendar throws ARIA violations in certain configurations #1636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ddaribo opened this issue Apr 2, 2025 · 0 comments · Fixed by #1637
Closed

[Bug] Calendar throws ARIA violations in certain configurations #1636

ddaribo opened this issue Apr 2, 2025 · 0 comments · Fixed by #1637
Assignees
@ddaribo
Labels
bug Something isn't working calendar ✅ status: resolved

Comments

@ddaribo
Copy link
Contributor

ddaribo commented Apr 2, 2025

Which component(s) are affected?

Calendar

Description

When visibleMonths is set to at least 2, for certain combinations of days-views, such as April+May, depending on the number of days, sometimes an empty "week" is rendered, where all days are hidden. This leads to a Certain ARIA roles must contain particular children violation.

Image

Reproduction

  1. Set visibleMonths to 2
  2. Go to April 2025

Workaround

In case all days in a week are hidden, the week should have aria-hidden set to true, or not be rendered at all?

Is this a regression?

No or unsure. This never worker, or I haven't tried before.

Affected versions

5.3.0

Browser/OS/Node environment

Chrome, Mozilla, etc.
@ddaribo ddaribo added 🆕 status: new The issue is new and will be reviewed when somebody picks it up. bug Something isn't working calendar labels Apr 2, 2025
@ddaribo ddaribo self-assigned this Apr 2, 2025
@ddaribo ddaribo changed the title Calendar throws ARIA violations in certain configurations [Bug] Calendar throws ARIA violations in certain configurations Apr 2, 2025
@ddaribo ddaribo mentioned this issue Apr 2, 2025
Merged
@ddaribo ddaribo added ✅ status: resolved and removed 🆕 status: new The issue is new and will be reviewed when somebody picks it up. labels Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddaribo ddaribo

Labels
bug Something isn't working calendar ✅ status: resolved
Projects
None yet
Milestone
No milestone
1 participant
@ddaribo